Skip to content

Add IP Allow List Events to Org Security Audit Log Review#10261

Merged
ethanpalm merged 6 commits intomainfrom
add_ip_allow_list_entries
Oct 4, 2021
Merged

Add IP Allow List Events to Org Security Audit Log Review#10261
ethanpalm merged 6 commits intomainfrom
add_ip_allow_list_entries

Conversation

@Hollywood
Copy link
Copy Markdown

@Hollywood Hollywood commented Sep 23, 2021 •
edited
Loading

Why:

I noticed that the Audit Log Review docs didn't contain information regarding ip_allow_list and ip_allow_list_entry in the Organization Security section, so I updated the information on the page with that data.

What's being changed:

Below integration_installation_request I've added:

### `ip_allow_list` category actions

| Action | Description
|------------------|-------------------
| `enabled` | Triggered when an IP allow list was enabled for an organization.
| `disable` | Triggered when an IP allow list was disabled for an organization.
| `enable_for_installed_apps` | Triggered when an IP allow list was enabled for installed GitHub Apps.
| `disable_for_installed_apps` | Triggered when an IP allow list was disabled for installed GitHub Apps.

### `ip_allow_list_entry` category actions

| Action | Description
|------------------|-------------------
| `create` | Triggered when an IP address was added to an IP allow list.
| `update` | Triggered when an IP address or its description was changed.
| `destroy` | Triggered when an IP address was deleted from an IP allow list.

Check off the following:

  • I have reviewed my changes in staging (look for the latest deployment event in your pull request's timeline, then click View deployment).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

Adding ip_allow_list entries
0ea34f7 
I've added the ip_allow_list and ip_allow_list_entry category actions
@Hollywood Hollywood added the content This issue or pull request belongs to the Docs Content team label Sep 23, 2021
@welcome
Copy link
Copy Markdown

welcome bot commented Sep 23, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Sep 23, 2021
@felicitymay felicitymay removed their request for review September 23, 2021 17:32
@ramyaparimi ramyaparimi added waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Sep 23, 2021
@ramyaparimi
Copy link
Copy Markdown
Contributor

ramyaparimi commented Sep 23, 2021

@Hollywood
Thanks so much for opening a PR! I'll get this triaged for review ⚡

@Hollywood
Copy link
Copy Markdown
Author

Hollywood commented Sep 23, 2021

Any time @ramyaparimi!

ethanpalm
ethanpalm previously approved these changes Sep 29, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@ethanpalm ethanpalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋🏼 Thanks for creating this PR, @Hollywood! Your changes look great. I've just got one question and a few suggestions to replace product names with reusables. After incorporating these changes, I'll update the branch and get it merged when checks are passing. ⚡

Comment thread ...anizations/keeping-your-organization-secure/reviewing-the-audit-log-for-your-organization.md Outdated
Comment thread ...anizations/keeping-your-organization-secure/reviewing-the-audit-log-for-your-organization.md Outdated
Comment thread ...anizations/keeping-your-organization-secure/reviewing-the-audit-log-for-your-organization.md Outdated
@thari44 thari44 mentioned this pull request Oct 1, 2021
Closed
@Dez6ztt

This comment has been minimized.

Sign in to view
@ethanpalm
Update content/organizations/keeping-your-organization-secure/reviewi…
a642964 
…ng-the-audit-log-for-your-organization.md

Co-authored-by: Ethan Palm <56270045+ethanpalm@users.noreply.github.com>
Jonathan Cardona and others added 2 commits October 3, 2021 22:41
@ethanpalm
Update content/organizations/keeping-your-organization-secure/reviewi…
0e2447d 
…ng-the-audit-log-for-your-organization.md

Co-authored-by: Ethan Palm <56270045+ethanpalm@users.noreply.github.com>
@ethanpalm
Update content/organizations/keeping-your-organization-secure/reviewi…
0558a07 
…ng-the-audit-log-for-your-organization.md
ethanpalm
ethanpalm previously approved these changes Oct 4, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@ethanpalm ethanpalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Changes look great.

@ethanpalm ethanpalm added ready to merge This pull request is ready to merge and removed waiting for review Issue/PR is waiting for a writer's review labels Oct 4, 2021
@ethanpalm ethanpalm enabled auto-merge October 4, 2021 21:04
@ethanpalm ethanpalm merged commit 28925a6 into main Oct 4, 2021
@ethanpalm ethanpalm deleted the add_ip_allow_list_entries branch October 4, 2021 21:15
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 4, 2021

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@Dstiers1191
Copy link
Copy Markdown

Dstiers1191 commented Oct 4, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ethanpalm ethanpalm ethanpalm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Hollywood @ramyaparimi @Dez6ztt @Dstiers1191 @ethanpalm @docubot