Skip to content

Update adding-a-new-ssh-key-to-your-github-account.md#10193

Closed
factoidforrest wants to merge 1 commit into
github:mainfrom
factoidforrest:patch-2
Closed

Update adding-a-new-ssh-key-to-your-github-account.md#10193
factoidforrest wants to merge 1 commit into
github:mainfrom
factoidforrest:patch-2

Conversation

@factoidforrest
Copy link
Copy Markdown

@factoidforrest factoidforrest commented Sep 20, 2021 •
edited
Loading

Because cloning with https is actually the default option in Github's web UI, this is a major gotcha for anyone wanting to set up SSH auth, which will be most users. I'm an experienced dev and I've gotten stuck on this twice now.

Why:

Closes [issue link]

What's being changed:

Check off the following:

  • I have reviewed my changes in staging (look for the latest deployment event in your pull request's timeline, then click View deployment).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@factoidforrest
Update adding-a-new-ssh-key-to-your-github-account.md
ae58391 
Because cloning with https is actually the default option in Github's web UI, this is a major gotcha for anyone wanting to set up SSH auth, which will be most users.  I'm an experienced dev and I've gotten stuck on this twice now.
@welcome
Copy link
Copy Markdown

welcome Bot commented Sep 20, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Sep 20, 2021
@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Sep 21, 2021
@ramyaparimi
Copy link
Copy Markdown
Contributor

ramyaparimi commented Sep 21, 2021

@factoidforrest
Thanks so much for opening a PR! I'll get this triaged for review ⚡

@lecoursen
Copy link
Copy Markdown
Member

lecoursen commented Oct 5, 2021

Hi @factoidforrest, this is conceptual information rather than procedural, so it belongs in the conceptual section above the procedure. We already do address this subject to some extent, here:

image

However, I can see how that could be fleshed out a bit more! Feel free to move some of the content you added there, and then let us know this is ready for another review!

@lecoursen lecoursen removed the waiting for review Issue/PR is waiting for a writer's review label Oct 5, 2021
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 13, 2021

A stale label has been added to this pull request because it has been open 7 days with no activity. To keep this PR open, add a comment or push a commit within 3 days.

@github-actions github-actions Bot added the stale There is no recent activity on this issue or pull request label Oct 13, 2021
@github-actions github-actions Bot closed this Oct 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

content This issue or pull request belongs to the Docs Content team stale There is no recent activity on this issue or pull request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@factoidforrest @ramyaparimi @lecoursen