Skip to content

feat: set up mobile ad specific for OS type#43422

Closed
EhEhRon91 wants to merge 16 commits intofreeCodeCamp:mainfrom
EhEhRon91:feat/mobile-ad-for-app
Closed

feat: set up mobile ad specific for OS type#43422
EhEhRon91 wants to merge 16 commits intofreeCodeCamp:mainfrom
EhEhRon91:feat/mobile-ad-for-app

Conversation

@EhEhRon91
Copy link
Copy Markdown
Contributor

@EhEhRon91 EhEhRon91 commented Sep 9, 2021

Checklist:

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the main branch of freeCodeCamp.
  • I have tested these changes either locally on my machine, or GitPod.

Closes #43350

For now the modal will appear on the main page. Currently it uses localStorage to define a variable to only display the modal once after dismissing the ad.

@EhEhRon91 EhEhRon91 requested a review from a team September 9, 2021 12:28
@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Sep 9, 2021

@github-actions github-actions bot added the platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. label Sep 9, 2021
majestic-owl448
majestic-owl448 reviewed Sep 9, 2021
View reviewed changes
@github-actions github-actions bot added the scope: i18n language translation/internationalization. Often combined with language type label label Sep 9, 2021
raisedadead
raisedadead reviewed Sep 10, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@raisedadead raisedadead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am wondering if we can use: https://github.com/lancedikson/bowser, for this. It's pretty darn neat and will help us avoid any future maintenance to the detection logic?

@EhEhRon91
Copy link
Copy Markdown
Contributor Author

EhEhRon91 commented Sep 10, 2021

Bowser seems to work quite nicely!

raisedadead
raisedadead previously approved these changes Sep 10, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@raisedadead raisedadead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @nhcarrigan what do you think?

@raisedadead raisedadead added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Sep 10, 2021
naomi-lgbt
naomi-lgbt reviewed Sep 10, 2021
View reviewed changes
ojeytonwilliams
ojeytonwilliams requested changes Sep 14, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@ojeytonwilliams ojeytonwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks @EhEhRon91

I did find a few things I think should be changed, but nothing serious:

ojeytonwilliams
ojeytonwilliams previously approved these changes Sep 17, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@ojeytonwilliams ojeytonwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this except for the issue that @nhcarrigan raised.

@Sembauke
Copy link
Copy Markdown
Member

Sembauke commented Sep 30, 2021

Hey @EhEhRon91, can you add the suggested change from @nhcarrigan, so we can merge your pull request.

@raisedadead raisedadead added status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. status: waiting update Is awaiting update, after feedback or request for changes and removed status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. labels Oct 1, 2021
@Sembauke Sembauke removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Oct 4, 2021
@gikf
Copy link
Copy Markdown
Member

gikf commented Oct 25, 2021

Hey @EhEhRon91

did you have a chance to look at last unresolved conversation here?

@ghost

This comment has been minimized.

Sign in to view
@gikf gikf removed the status: waiting update Is awaiting update, after feedback or request for changes label Oct 26, 2021
@raisedadead raisedadead added the MERGE CONFLICT! To be applied to PR's that have a merge conflict and need updating label Nov 2, 2021
Nirajn2311
Nirajn2311 previously requested changes Nov 4, 2021
View reviewed changes
Sembauke
Sembauke previously approved these changes Nov 5, 2021
View reviewed changes
@Sembauke Sembauke requested a review from raisedadead November 5, 2021 09:27
ojeytonwilliams
ojeytonwilliams previously requested changes Nov 5, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@ojeytonwilliams ojeytonwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not add bowser until we need it. We might change our minds about this feature, delete the comments and then forget about the package.

@raisedadead
Copy link
Copy Markdown
Member

raisedadead commented Nov 8, 2021

IMHO, I think we should put this behind a feature flag.

To be honest, the requirement was already clearly defined. The OP also implemented the same. I am willing to close the PR as is if all think the same is an appropriate & fair course of action.

@Sembauke Sembauke removed status: waiting update Is awaiting update, after feedback or request for changes MERGE CONFLICT! To be applied to PR's that have a merge conflict and need updating labels Nov 10, 2021
@raisedadead raisedadead added the MERGE CONFLICT! To be applied to PR's that have a merge conflict and need updating label Dec 2, 2021
@ShaunSHamilton ShaunSHamilton removed the MERGE CONFLICT! To be applied to PR's that have a merge conflict and need updating label Dec 8, 2021
@Sembauke Sembauke dismissed stale reviews from ojeytonwilliams and Nirajn2311 December 8, 2021 14:44

old review

@github-actions github-actions bot added the scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. label Dec 8, 2021
@Sembauke Sembauke added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Dec 8, 2021
@Sembauke Sembauke requested a review from Nirajn2311 December 8, 2021 16:17
@raisedadead
Copy link
Copy Markdown
Member

raisedadead commented Jan 7, 2022

I am auditing PRs in limbo. @Sembauke can you guide with the next action items?

@Sembauke Sembauke closed this Feb 2, 2022
@Sembauke Sembauke added the status: decayed Stale issues that need follow up from commentators. Were closed for inactivity label Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@majestic-owl448 majestic-owl448 majestic-owl448 left review comments

@naomi-lgbt naomi-lgbt naomi-lgbt left review comments

@Sembauke Sembauke Sembauke left review comments

@raisedadead raisedadead Awaiting requested review from raisedadead

@ojeytonwilliams ojeytonwilliams Awaiting requested review from ojeytonwilliams

@Nirajn2311 Nirajn2311 Awaiting requested review from Nirajn2311

Assignees

@Sembauke Sembauke

Labels

platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: i18n language translation/internationalization. Often combined with language type label scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. status: decayed Stale issues that need follow up from commentators. Were closed for inactivity status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Detect OS and advertise mobile app

9 participants

@EhEhRon91 @Sembauke @gikf @raisedadead @ojeytonwilliams @majestic-owl448 @Nirajn2311 @naomi-lgbt @ShaunSHamilton