bpo-45193: Restore IDLE completion boxes on Ubuntu #28343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The line that should not have been needed on macOS tk 8.6.8 but was, should not be a problem on Ubuntu, but is. It is not needed on macOS tk 8.6.11, installed with 3.10. Disable it but leave it for now in case some system needs it.
terryjreedy
added
type-bug
taleinat
approved these changes
Sep 15, 2021
|
LGTM! I do think this should be noted clearly in NEWS though. |
|
I will make a new PR for a news item while the backport is tested. I just had to run the tests three times to be allowed to merge #28344 and I don't want to take the chance of another fake failure. |
|
Thanks @terryjreedy for the PR |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 15, 2021
The line that should not have been needed on macOS tk 8.6.8 but was, should not be a problem on Ubuntu, but is. It is not needed on macOS tk 8.6.11, installed with 3.10. Disable it but leave it for now in case some system needs it. (cherry picked from commit 1afc7b3) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
|
GH-28347 is a backport of this pull request to the 3.10 branch. |
miss-islington
added a commit
that referenced
this pull request
Sep 15, 2021
The line that should not have been needed on macOS tk 8.6.8 but was, should not be a problem on Ubuntu, but is. It is not needed on macOS tk 8.6.11, installed with 3.10. Disable it but leave it for now in case some system needs it. (cherry picked from commit 1afc7b3) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
pablogsal
pushed a commit
that referenced
this pull request
Sep 19, 2021
The line that should not have been needed on macOS tk 8.6.8 but was, should not be a problem on Ubuntu, but is. It is not needed on macOS tk 8.6.11, installed with 3.10. Disable it but leave it for now in case some system needs it. (cherry picked from commit 1afc7b3) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The line that should not have been needed on macOS tk 8.6.8 but was,
should not be a problem on Ubuntu, but is. It is not needed on macOS
tk 8.6.11, installed with 3.10. Disable it but leave it for
now in case some system needs it.
https://bugs.python.org/issue45193