CPP: Add query for CWE-1041 Use of Redundant Code #6710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathiasVP
reviewed
Sep 20, 2021
cpp/ql/src/experimental/Security/CWE/CWE-1041/FindWrapperFunctions.ql
Outdated
Show resolved
Hide resolved
cpp/ql/src/experimental/Security/CWE/CWE-1041/FindWrapperFunctions.ql
Outdated
Show resolved
Hide resolved
cpp/ql/src/experimental/Security/CWE/CWE-1041/FindWrapperFunctions.ql
Outdated
Show resolved
Hide resolved
cpp/ql/src/experimental/Security/CWE/CWE-1041/FindWrapperFunctions.ql
Outdated
Show resolved
Hide resolved
cpp/ql/src/experimental/Security/CWE/CWE-1041/FindWrapperFunctions.ql
Outdated
Show resolved
Hide resolved
cpp/ql/src/experimental/Security/CWE/CWE-1041/FindWrapperFunctions.ql
Outdated
Show resolved
Hide resolved
MathiasVP
reviewed
Sep 20, 2021
cpp/ql/src/experimental/Security/CWE/CWE-1041/FindWrapperFunctions.qhelp
Show resolved
Hide resolved
cpp/ql/src/experimental/Security/CWE/CWE-1041/FindWrapperFunctions.qhelp
Outdated
Show resolved
Hide resolved
Co-authored-by: Mathias Vorreiter Pedersen <mathiasvp@github.com>
1 task
MathiasVP
reviewed
Oct 8, 2021
cpp/ql/src/experimental/Security/CWE/CWE-1041/FindWrapperFunctions.ql
Outdated
Show resolved
Hide resolved
…ions.ql Co-authored-by: Mathias Vorreiter Pedersen <mathiasvp@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this query looks for functions for which there are wrapper functions with validation of arguments or work results.
the presence of wrapper functions already speaks of the developer's desire to ensure the launch of the function with additional safety. however, situations are possible when the developer has created a purely functional shell,
In this case, the detector will be useful in terms of assessing the need for an additional wrapper function.
From the specifics of the request, note the need to augment getEnclosingFunction when multifunctional functions are available. getEnclosingFunction may not work as expected. to fix these problems i used getFile.
links to real work results, I will add later. I am currently working on them with developers.
jackaudio/jack2#796