Skip to content

/ superset Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[time_picker]start date display is not inclusive #16462

Open
2 tasks
nguyenluongky opened this issue Aug 26, 2021 · 2 comments
Open
2 tasks

[time_picker]start date display is not inclusive #16462

nguyenluongky opened this issue Aug 26, 2021 · 2 comments
Assignees
@junlincc
Labels
#bug good first issue viz:explore:timepick

Comments

@nguyenluongky
Copy link

@nguyenluongky nguyenluongky commented Aug 26, 2021 •
edited

Currently, we use Native filter on Superset version 1.2, but looks like The actual time range does not show correctly with SIP-15 (in the SIP-15 the time range must is [inclusive, exclusive) ). So that mean the actual time range and the tool tip must show label as: from_date <= col < to_date.

Expected results

image

Actual results

image

Environment

(please complete the following information):

  • superset version: 1.2
  • python version: `3.7

Checklist

  • I have rated this issue on slack community and they advice me to create a ticket.
  • I tried with the config SIP_15_DEFAULT_TIME_RANGE_ENDPOINTS = ["inclusive", "inclusive"] but doesn't help.
@junlincc junlincc changed the title The Actual time range not show correct with SIP-15 on Superset version 1.2 [time_picker]start date display is not inclusive Aug 26, 2021
@junlincc
Copy link
Member

@junlincc junlincc commented Aug 26, 2021

thanks for reporting, if you click view query from dashboard with a time filter, you will notice the query is actually accurate even though the display is wrong. we will push a fix for the display soon.
Screen Shot 2021-08-26 at 10 53 54 AM
Screen Shot 2021-08-26 at 10 54 01 AM

@junlincc junlincc self-assigned this Aug 26, 2021
@nguyenluongky
Copy link
Author

@nguyenluongky nguyenluongky commented Aug 27, 2021

Thanks @junlincc ,
The query is correct, It is just a problem on UI only so it makes confuse for end-user then :).
And I also noted that this problem occurred because of Native filter doesn't submit the time_range_endpoints so by default it always use < operator to display. Correct me if I wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@junlincc junlincc

Labels
#bug good first issue viz:explore:timepick
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@nguyenluongky @junlincc