stream: fix highwatermark threshold and add the missing error #38700
+18
−3
Conversation
|
Considering that the 2nd is a semver major, do I need to move the 1st to a seperated PR? |
|
lgtm |
It's probably better to. |
After a closer look, it seems unnecessary to make another PR. node/lib/internal/streams/readable.js Lines 359 to 361 in 910efc2 |
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
|
I think this needs a rebase against master. |
pd4d10
force-pushed the
pd4d10:patch-stream-highwatermark
branch
from
2fbbc9f
to
e45be56
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
|
Can you please rebase to fix the git conflict? |
pd4d10
force-pushed the
pd4d10:patch-stream-highwatermark
branch
from
e45be56
to
dbba797
1. Fix highwatermark threshold: `< 1GiB` -> `<= 1GiB` 2. Add the missing error: Size out of range Update test/parallel/test-streams-highwatermark.js Co-authored-by: Darshan Sen <raisinten@gmail.com>
pd4d10
force-pushed the
pd4d10:patch-stream-highwatermark
branch
from
dbba797
to
0d5c202
|
lgtm |
Commit Queue failed- Loading data for nodejs/node/pull/38700 ✔ Done loading data for nodejs/node/pull/38700 ----------------------------------- PR info ------------------------------------ Title stream: fix highwatermark threshold and add the missing error (#38700) Author Rongjian Zhang (@pd4d10) Branch pd4d10:patch-stream-highwatermark -> nodejs:master Labels stream, semver-major, needs-citgm Commits 1 - stream: fix highwatermark threshold and add the missing error Committers 1 - Rongjian Zhang PR-URL: https://github.com/nodejs/node/pull/38700 Reviewed-By: Matteo Collina Reviewed-By: James M Snell Reviewed-By: Antoine du Hamel ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/38700 Reviewed-By: Matteo Collina Reviewed-By: James M Snell Reviewed-By: Antoine du Hamel -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 16 May 2021 13:51:24 GMT ✔ Approvals: 3 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/38700#pullrequestreview-747718670 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/38700#pullrequestreview-666844368 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/38700#pullrequestreview-746121508 ✔ Last GitHub Actions successful ℹ Last Full PR CI on 2021-07-04T05:51:52Z: https://ci.nodejs.org/job/node-test-pull-request/38840/ ⚠ Commits were pushed after the last Full PR CI run: ⚠ - stream: fix highwatermark threshold and add the missing error - Querying data for job/node-test-pull-request/38840/ ✔ Build data downloaded - Querying failures of job/node-test-commit/47512/ ✔ Data downloaded ✖ 10 failure(s) on the last Jenkins CI run -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1208763201 |
|
Landed in b016d5d...0c6f345 |
nodejs-github-bot
added a commit
that referenced
this pull request
Sep 7, 2021
1. Fix highwatermark threshold: `< 1GiB` -> `<= 1GiB` 2. Add the missing error: Size out of range Update test/parallel/test-streams-highwatermark.js Co-authored-by: Darshan Sen <raisinten@gmail.com> PR-URL: #38700 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
< 1GiB-><= 1GiB, doc here