Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation fails for dependencies which do not contain a package.json #1866

Open
jeremyjs opened this issue Jun 5, 2019 · 1 comment
Open

Comments

@jeremyjs
Copy link

@jeremyjs jeremyjs commented Jun 5, 2019

When I tried to install with a dependency which is a git repo and does not contain a package.json file, the installation fails.

jeremy@rhaegal server (master) $ pnpm install
 ERROR  ENOENT: no such file or directory, open '/Users/jeremy/.pnpm-store/2/github.com/jeremyjs/Open-API-2.0-protobuf-messages/4868a7cb50ef3ee9820b9b384cf0290bc5fedb82/_tmp_94939_898594f423d7b6d93f81bd0282ddc5ec/package.json'
Resolving: total 848, reused 114, downloaded 695
Error: ENOENT: no such file or directory, open '/Users/jeremy/.pnpm-store/2/github.com/jeremyjs/Open-API-2.0-protobuf-messages/4868a7cb50ef3ee9820b9b384cf0290bc5fedb82/_tmp_94939_898594f423d7b6d93f81bd0282ddc5ec/package.json'
Error: ENOENT: no such file or directory, open '/Users/jeremy/.pnpm-store/2/github.com/jeremyjs/Open-API-2.0-protobuf-messages/4868a7cb50ef3ee9820b9b384cf0290bc5fedb82/_tmp_94939_898594f423d7b6d93f81bd0282ddc5ec/package.json'

Link to relevant github repository: https://github.com/jeremyjs/Open-API-2.0-protobuf-messages

Suggested fix is to check for the existence of a package.json and simply print a warning rather than failing hard.

pnpm version:

jeremy@rhaegal server (master) $ pnpm --version
3.4.1
@zkochan
Copy link
Member

@zkochan zkochan commented Jul 14, 2019

Seems like Yarn supports it but npm does not. I have no objections to supporting this in pnpm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.