Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use consistent wording for "out of memory" / "memory allocation failed" error messages #1025

Open
TimWolla opened this issue Jan 3, 2021 · 2 comments

Comments

@TimWolla
Copy link
Member

@TimWolla TimWolla commented Jan 3, 2021

Currently we have a mix of:

  • Out of memory error.
  • Out of memory error
  • out of memory error
  • out of memory
  • out of memory.
  • out of memory [some context]

All these should be adjusted to use the same wording for consistency and it should also make the executable a little bit smaller 😄

@wtarreau
Copy link
Member

@wtarreau wtarreau commented Jan 5, 2021

I think it could slightly depend on the context. For example at the beginning of a sentence you'll have an upper case but not in the middle. Similarly there might be some occurrences of "error: %s" where it's better to have "error: out of memory" than "error: out of memory error". But I sincerely doubt we have that many different contexts and it's likely that 2 or 3 at most would be needed.

@TimWolla
Copy link
Member Author

@TimWolla TimWolla commented Jan 5, 2021

Yes, it's not a 100% mindless search and replace. I did look into a few places while writing up this issue: Most of them have exactly the same context (usually config parsing) and are worded slightly differently. Adjusting all the ones in the config parser and similar is a no brainer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants