chore: background color tests and refactoring#9210
Closed
farfromrefug wants to merge 6 commits into
Closed
Conversation
rigor789
reviewed
Feb 12, 2021
oups Co-authored-by: Igor Randjelovic <rigor789@gmail.com>
Contributor
|
@farfromrefug can you confirm if this is still valid? or were these changes included in a different PR? https://github.com/NativeScript/NativeScript/pull/9615/files |
Collaborator
Author
|
@NathanWalker the tests are. But i dont think.the rest is |
Contributor
|
Thanks @farfromrefug for the extra tests, added them from this PR directly to main here: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the issues about background color i added some tests to check for setting a color then removing it.
I also refactored a bit to try and make it more understandable. i hope we have enough tests and that i did not break anything :s