add bz2 from CPython 3.10.5 #2444
Merged
+621
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
verhovsky
force-pushed
the
add-bz2
branch
5 times, most recently
from
7685368
to
0ea2868
Compare
coolreader18
reviewed
Feb 11, 2021
vm/src/stdlib/bz2.rs
Outdated
| BZ2Compressor::make_class(ctx); | ||
|
|
||
| py_module!(vm, "_bz2", { | ||
| "BZ2Decompressor" => named_function!(ctx, _bz2, BZ2Decompressor), |
There was a problem hiding this comment.
I know this is a WIP, but just a note - it looks like CPython exports _bz2.BZ2[De]compressor as the classes, rather as separate functions. You can move the functionality from _bz2_BZ2Decompressor to an associated function BZ2Decompressor::tp_new, with a #[pyslot] attribute on it, and same with BZ2Compressor. Then you can export directly as "BZ2Decompressor" => BZ2Decompressor::make_class(ctx)
verhovsky
force-pushed
the
add-bz2
branch
2 times, most recently
from
9f28790
to
13a0b61
Compare
youknowone
force-pushed
the
add-bz2
branch
2 times, most recently
from
7a6843d
to
a625167
Compare
Co-Authored-By: Jeong YunWon <jeong@youknowone.org>
fanninpm
reviewed
Aug 4, 2022
stdlib/src/lib.rs
Outdated
| @@ -25,6 +25,8 @@ mod random; | |||
| mod statistics; | |||
| // TODO: maybe make this an extension module, if we ever get those | |||
| // mod re; | |||
| #[cfg(not(any(target_arch = "wasm32")))] | |||
There was a problem hiding this comment.
Suggested change
| #[cfg(not(any(target_arch = "wasm32")))] | |
| #[cfg(not(target_arch = "wasm32"))] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
pretty much copy and pasted from
csv.rs.