Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-44524: Make exc msg more useful when subclass from special form #27710

Merged
merged 1 commit into from Aug 18, 2021
Merged

bpo-44524: Make exc msg more useful when subclass from special form #27710

merged 1 commit into from Aug 18, 2021

Conversation

@uriyyo
Copy link
Member

@uriyyo uriyyo commented Aug 10, 2021 •
edited by bedevere-bot

https://bugs.python.org/issue44524
@uriyyo uriyyo requested a review from gvanrossum as a code owner Aug 10, 2021
@uriyyo
Copy link
Member Author

@uriyyo uriyyo commented Aug 10, 2021 •
edited by bedevere-bot

@ambv This PR will fix issue that you mention at bpo-44524

@ambv ambv merged commit a3a4d20 into python:main Aug 18, 2021
13 checks passed
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Aug 18, 2021

Thanks @uriyyo for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Aug 18, 2021

GH-27815 is a backport of this pull request to the 3.10 branch.

miss-islington added a commit to miss-islington/cpython that referenced this issue Aug 18, 2021
@uriyyo @miss-islington
bpo-44524: Fix cryptic TypeError message when trying to subclass spec…
f49006c 
…ial forms in `typing` (pythonGH-27710)

This was a Python 3.9 regression.
(cherry picked from commit a3a4d20)

Co-authored-by: Yurii Karabas <1998uriyyo@gmail.com>
miss-islington added a commit that referenced this issue Aug 28, 2021
@uriyyo @miss-islington
bpo-44524: Fix cryptic TypeError message when trying to subclass spec…
81fa08c 
…ial forms in `typing` (GH-27710)

This was a Python 3.9 regression.
(cherry picked from commit a3a4d20)

Co-authored-by: Yurii Karabas <1998uriyyo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
5 participants
@uriyyo @miss-islington @bedevere-bot @ambv @the-knights-who-say-ni