Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-42892: fix email multipart attribute error #26903

Merged
merged 8 commits into from Jul 30, 2021
Merged

bpo-42892: fix email multipart attribute error #26903

merged 8 commits into from Jul 30, 2021

Conversation

@akulakov
Copy link
Contributor

@akulakov akulakov commented Jun 24, 2021 •
edited by bedevere-bot

Based on the patch by @bitdancer in the ticket.
Unit test updates by Andrei K.

https://bugs.python.org/issue42892
@akulakov akulakov requested a review from as a code owner Jun 24, 2021
iritkatriel
iritkatriel reviewed Jun 27, 2021
View changes
Lib/test/test_email/test_message.py Outdated Show resolved Hide resolved
Lib/test/test_email/test_message.py Outdated Show resolved Hide resolved
@akulakov
Copy link
Contributor Author

@akulakov akulakov commented Jun 28, 2021

@iritkatriel I pushed an update, please take a look.. note the test failure is unrelated to the PR (it says that grammar.new file is missing).

@iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Jun 28, 2021

LGTM, but would be good if @bitdancer also had a look.

@akulakov
Copy link
Contributor Author

@akulakov akulakov commented Jun 28, 2021

@iritkatriel thanks for the review :)

@iritkatriel iritkatriel requested a review from bitdancer Jul 15, 2021
@ambv ambv merged commit e3f877c into python:main Jul 30, 2021
12 of 13 checks passed
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jul 30, 2021

Thanks @akulakov for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

miss-islington added a commit to miss-islington/cpython that referenced this issue Jul 30, 2021
@akulakov @miss-islington
bpo-42892: fix email multipart attribute error (pythonGH-26903)
a74974f 
(cherry picked from commit e3f877c)

Co-authored-by: andrei kulakov <andrei.avk@gmail.com>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jul 30, 2021

GH-27492 is a backport of this pull request to the 3.10 branch.

miss-islington added a commit to miss-islington/cpython that referenced this issue Jul 30, 2021
@akulakov @miss-islington
bpo-42892: fix email multipart attribute error (pythonGH-26903)
3a2b602 
(cherry picked from commit e3f877c)

Co-authored-by: andrei kulakov <andrei.avk@gmail.com>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jul 30, 2021

GH-27493 is a backport of this pull request to the 3.9 branch.

ambv pushed a commit that referenced this issue Jul 30, 2021
@akulakov @miss-islington
bpo-42892: fix email multipart attribute error (GH-26903) (GH-27492)
6f95002 
(cherry picked from commit e3f877c)

Co-authored-by: andrei kulakov <andrei.avk@gmail.com>
ambv pushed a commit that referenced this issue Jul 30, 2021
@akulakov @miss-islington
bpo-42892: fix email multipart attribute error (GH-26903) (GH-27493)
0f42b72 
(cherry picked from commit e3f877c)

Co-authored-by: andrei kulakov <andrei.avk@gmail.com>
JuniorJPDJ added a commit to JuniorJPDJ/cpython that referenced this issue Aug 12, 2021
@akulakov @JuniorJPDJ
bpo-42892: fix email multipart attribute error (pythonGH-26903)
d442645
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iritkatriel iritkatriel

@python/email-team email-team

@bitdancer bitdancer

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
6 participants
@akulakov @iritkatriel @miss-islington @bedevere-bot @ambv @the-knights-who-say-ni