New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-44404: tkinter `after` support callable classes #26812

Merged

serhiy-storchaka merged 5 commits into python:main from E-Paine:tkinter-callable-class

Jun 23, 2021

Contributor

E-Paine commented Jun 20, 2021 •

edited by bedevere-bot

https://bugs.python.org/issue44404


          tkinter support callable classes

10b4120

the-knights-who-say-ni added the CLA signed label

bedevere-bot added the awaiting review label


          📜🤖 Added by blurb_it.

ce2b726

Contributor Author

E-Paine commented Jun 20, 2021

Quick note: as far as I can tell, all other usages of __name__ are safe (i.e. not going to raise an AttributeError).

E-Paine changed the title ~~bpo-44404: tkinter support callable classes~~ bpo-44404: tkinter after support callable classes

serhiy-storchaka reviewed

View changes

Member

serhiy-storchaka left a comment

Please add tests.

serhiy-storchaka reviewed

View changes

Misc/NEWS.d/next/Library/2021-06-20-19-01-11.bpo-44404.McfrYB.rst Outdated Show resolved Hide resolved

E-Paine and others added 2 commits


          news rephrasing

c23ee2e

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>


          Add tests

66eb621

Contributor Author

E-Paine commented Jun 20, 2021

Pipelines failure is related to issue 44384

E-Paine requested a review from serhiy-storchaka

serhiy-storchaka reviewed

View changes

Lib/tkinter/test/test_tkinter/test_misc.py Show resolved Hide resolved


          Use functools.partial

1acb78c

Contributor Author

E-Paine commented Jun 22, 2021

@serhiy-storchaka please could you set the Windows x64 test to rerun (it failed due to a connection issue - presumably temporary)

serhiy-storchaka approved these changes

View changes

Member

serhiy-storchaka left a comment

LGTM.

bedevere-bot added awaiting merge and removed awaiting review labels

serhiy-storchaka merged commit e9c8f78 into python:main

13 checks passed

bedevere-bot removed the awaiting merge label

serhiy-storchaka added the needs backport to 3.10 label

Contributor

miss-islington commented Jun 23, 2021

Thanks @E-Paine for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

Contributor

miss-islington commented Jun 23, 2021

Sorry @E-Paine and @serhiy-storchaka, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker e9c8f784fa13ea3a51df3b72a498a3896ec9e768 3.10

miss-islington assigned serhiy-storchaka

This comment was marked as off-topic.

Sign in to view

Contributor Author

E-Paine commented Jun 24, 2021

Great, thanks Serhiy!

E-Paine deleted the tkinter-callable-class branch

terryjreedy added needs backport to 3.10 and removed needs backport to 3.10 labels

Contributor

miss-islington commented Jun 26, 2021

Thanks @E-Paine for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

Contributor

miss-islington commented Jun 26, 2021

Sorry @E-Paine and @serhiy-storchaka, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker e9c8f784fa13ea3a51df3b72a498a3896ec9e768 3.10

terryjreedy added needs backport to 3.10 and removed needs backport to 3.10 labels

Contributor

miss-islington commented Jun 26, 2021

Thanks @E-Paine for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

bedevere-bot commented Jun 26, 2021

GH-26921 is a backport of this pull request to the 3.10 branch.

bedevere-bot removed the needs backport to 3.10 label

miss-islington added a commit to miss-islington/cpython that referenced this issue


          bpo-44404: tkinter after support callable classes (pythonGH-26812)

(cherry picked from commit e9c8f78)

Co-authored-by: E-Paine <63801254+E-Paine@users.noreply.github.com>

Member

terryjreedy commented Jun 26, 2021 •

edited

Buildbot failure in test_compile (hiddden) is
test_stack_overflow (test.test_compile.TestSpecifics) ... *** Signal 9

This is first time I have seen 'trouble checking out...' twice on one issue. Trying again.
... and it worked this time.

miss-islington added a commit that referenced this issue


          bpo-44404: tkinter after support callable classes (GH-26812)

e1f3bd2

(cherry picked from commit e9c8f78)

Co-authored-by: E-Paine <63801254+E-Paine@users.noreply.github.com>

pablogsal mentioned this pull request

[3.10] Correct the order of regen-abidump #27228

Closed

JuniorJPDJ added a commit to JuniorJPDJ/cpython that referenced this issue


          bpo-44404: tkinter after support callable classes (pythonGH-26812)

3359e56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment