➜
This issue tracker will soon become read-only and move to GitHub.
For a smoother transition, remember to
log in and link your GitHub username to your profile.
For more information,
see this post about the migration.
Created on 2021-05-14 04:53 by dhillier, last changed 2021-09-09 08:44 by vxgmichel. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 26118 | merged | dhillier, 2021-05-14 05:36 | |
| Messages (3) | |||
|---|---|---|---|
| msg393622 - (view) | Author: Daniel Hillier (dhillier) * | Date: 2021-05-14 04:53 | |
In the zipfile module, masking of bit flags is done against hex numbers eg. if flags & 0x800... To increase readability I suggest we replace these with global variables named for the purpose of the flag. From the example above: if flags & 0x800 becomes: if flags & _MASK_UTF_FILENAME |
|||
| msg396906 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) *  |
Date: 2021-07-03 14:38 | |
New changeset 556d5ad11fb380868c19beeba53d49f89c27f32d by Daniel Hillier in branch 'main': bpo-44129: Add descriptive global variables for general purpose bit flags (GH-26118) https://github.com/python/cpython/commit/556d5ad11fb380868c19beeba53d49f89c27f32d |
|||
| msg396907 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2021-07-03 14:39 | |
Thank you for your contribution Daniel. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2021-09-09 08:44:42 | vxgmichel | set | pull_requests: - pull_request26670 |
| 2021-09-09 08:40:38 | vxgmichel | set | nosy:
+ vxgmichel pull_requests: + pull_request26670 |
| 2021-07-03 14:39:18 | serhiy.storchaka | set | status: open -> closed versions: - Python 3.10 messages: + msg396907 resolution: fixed stage: patch review -> resolved |
| 2021-07-03 14:38:10 | serhiy.storchaka | set | messages: + msg396906 |
| 2021-05-14 05:36:52 | dhillier | set | keywords:
+ patch stage: patch review pull_requests: + pull_request24763 |
| 2021-05-14 04:53:27 | dhillier | create | |