Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-44605: Teach @total_ordering() to work with metaclasses #27633

Merged
merged 1 commit into from Aug 6, 2021

Conversation

@rhettinger
Copy link
Contributor

@rhettinger rhettinger commented Aug 6, 2021

https://bugs.python.org/issue44605

ambv
ambv approved these changes Aug 6, 2021
@rhettinger rhettinger merged commit 1f7d646 into python:main Aug 6, 2021
13 checks passed
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Aug 6, 2021

Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒🤖

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Aug 6, 2021

GH-27640 is a backport of this pull request to the 3.10 branch.

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Aug 6, 2021

GH-27641 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit to miss-islington/cpython that referenced this issue Aug 6, 2021
…-27633)

(cherry picked from commit 1f7d646)

Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
miss-islington added a commit to miss-islington/cpython that referenced this issue Aug 6, 2021
…-27633)

(cherry picked from commit 1f7d646)

Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
@pablogsal
Copy link
Member

@pablogsal pablogsal commented Aug 6, 2021

@rhettinger Please, make sure you get at least a review from another core Dev before landing changes in the release candidate. I send several communications about this, the last one in this email:

https://mail.python.org/archives/list/python-dev@python.org/thread/RLO5Y6FPOPUJAJVN6MHRIKUSMSRUXUT6/

Here is the important extract:

Once the 3.10 branch reaches RC status, it only can have bug fixes applied that have been reviewed by other core developers (so you cannot merge your own PR without review even if you are a core dev). Generally, these issues must be severe enough (e.g. crashes) that they deserve fixing before the final release. All other issues should be deferred to the next development cycle (Python 3.10.1) since stability is the strongest concern at this point. Also bear in mind that once we reach the RC, the ABI is frozen and cannot change even for bug fixes.
While the goal is to have no code changes between an RC and a final release, there may be a need for final documentation o test fixes. Any such proposed changes should be discussed first with the release manager.
You cannot skip the peer review during an RC, no matter how small! Even if it is a simple copy-and-paste change, everything requires peer review from a core developer

@pablogsal
Copy link
Member

@pablogsal pablogsal commented Aug 6, 2021

My last message is in reference to the backport, not to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants