[3.10] bpo-40928: notify users running test_decimal on macOS of malloc warnings (GH-26783) #27628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngs (pythonGH-26783) * When trying to allocate very large regions on macOS, malloc does not fail silently. It sends a noisy error out to STDERR * This provides a helper function to warn the user, and provides the warning for test_decimal, which consistently generates these warnings on macOS. Co-authored-by: Łukasz Langa <lukasz@langa.pl> (cherry picked from commit 15d3c14) Co-authored-by: Jack DeVries <58614260+jdevries3133@users.noreply.github.com>
|
@jdevries3133 and @ambv: Status check is done, and it's a success ✅ . |
|
@jdevries3133 and @ambv: Status check is done, and it's a success ✅ . |
|
Test-only change affecting macOS only. |
pablogsal
approved these changes
Aug 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Łukasz Langa lukasz@langa.pl
(cherry picked from commit 15d3c14)
Co-authored-by: Jack DeVries 58614260+jdevries3133@users.noreply.github.com
https://bugs.python.org/issue40928