Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-43498: Fix dictionary iteration error in _ExecutorManagerThread #24868

Merged
merged 3 commits into from Nov 29, 2021
Merged

bpo-43498: Fix dictionary iteration error in _ExecutorManagerThread #24868

merged 3 commits into from Nov 29, 2021

Conversation

kulikjak
Copy link
Contributor

@kulikjak kulikjak commented Mar 15, 2021 •
edited by bedevere-bot

This prevents RuntimeError: dictionary changed size during iteration which we recently encountered several times during make install.

https://bugs.python.org/issue43498

@github-actions
Copy link

@github-actions github-actions bot commented Apr 15, 2021

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Apr 15, 2021
@kulikjak
Copy link
Contributor Author

@kulikjak kulikjak commented Apr 15, 2021

Still very much relevant.

@github-actions github-actions bot removed the stale label Apr 16, 2021
@sweeneyde
Copy link
Member

@sweeneyde sweeneyde commented Aug 3, 2021

Is it possible to find a test case that reliably (or usually) fails before this, and reliably passes after?

@kulikjak
Copy link
Contributor Author

@kulikjak kulikjak commented Aug 4, 2021

Is it possible to find a test case that reliably (or usually) fails before this, and reliably passes after?

I mentioned one way to force this in the issue, but you have to modify library files for that. I will look into reliably reproducing this with user code.

@mgorny
Copy link
Contributor

@mgorny mgorny commented Aug 5, 2021

Thanks for the patch. We're hitting this too, apparently, so I'll just backport it to Gentoo.

jameshilliard added a commit to jameshilliard/cpython that referenced this issue Oct 6, 2021
@kulikjak @jameshilliard
Fix dictionary iteration error in _ExecutorManagerThread
18ab883 
[Thomas: Taken from upstream pull request
python#24868, which is aimed at fixing
https://bugs.python.org/issue43498]
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
asvetlov
asvetlov reviewed Nov 29, 2021
View changes
Lib/concurrent/futures/process.py Outdated Show resolved Hide resolved
@asvetlov asvetlov merged commit 7431448 into python:main Nov 29, 2021
12 checks passed
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Nov 29, 2021

Thanks @kulikjak for the PR, and @asvetlov for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@asvetlov
Copy link
Contributor

@asvetlov asvetlov commented Nov 29, 2021

Thanks!

miss-islington added a commit to miss-islington/cpython that referenced this issue Nov 29, 2021
@miss-islington
bpo-43498: Fix dictionary iteration error in _ExecutorManagerThread (p…
6d4752e 
…ythonGH-24868)

(cherry picked from commit 7431448)

Co-authored-by: Jakub Kulík <Kulikjak@gmail.com>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Nov 29, 2021

GH-29836 is a backport of this pull request to the 3.10 branch.

miss-islington added a commit to miss-islington/cpython that referenced this issue Nov 29, 2021
@miss-islington
bpo-43498: Fix dictionary iteration error in _ExecutorManagerThread (p…
9fb5201 
…ythonGH-24868)

(cherry picked from commit 7431448)

Co-authored-by: Jakub Kulík <Kulikjak@gmail.com>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Nov 29, 2021

GH-29837 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this issue Nov 29, 2021
@miss-islington
bpo-43498: Fix dictionary iteration error in _ExecutorManagerThread (G…
4b11d71 
…H-24868)

(cherry picked from commit 7431448)

Co-authored-by: Jakub Kulík <Kulikjak@gmail.com>
miss-islington added a commit that referenced this issue Nov 29, 2021
@miss-islington
bpo-43498: Fix dictionary iteration error in _ExecutorManagerThread (G…
3b9d886 
…H-24868)

(cherry picked from commit 7431448)

Co-authored-by: Jakub Kulík <Kulikjak@gmail.com>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Nov 29, 2021

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86 Gentoo Installed with X 3.9 has failed when building commit 3b9d886.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/527/builds/326) and take a look at the build logs.
  4. Check if the failure is related to this commit (3b9d886) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/527/builds/326

Summary of the results of the build (if available):

Click to see traceback logs 
fatal: unable to access 'https://github.com/python/cpython.git/': Failed to connect to github.com port 443 after 131194 ms: Connection timed out

chmod: cannot access 'target/': No such file or directory

make: *** No rule to make target 'distclean'.  Stop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
7 participants
@kulikjak @sweeneyde @mgorny @miss-islington @asvetlov @bedevere-bot @the-knights-who-say-ni