fix(language-service): global autocomplete doesn't work when the user… #42923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
ivanwonder
force-pushed
the
global-autocomplete-when-re-edit-symbol
branch
from
eed05b7
to
be6d5ac
Compare
atscott
requested changes
Jul 28, 2021
ivanwonder
force-pushed
the
global-autocomplete-when-re-edit-symbol
branch
from
be6d5ac
to
3ddbaf9
Compare
… tries to modify the symbol When the user tries to trigger suggestions from an interruption, the LS should provide the global completions. For example, `[input]="t¦"`, the `t` can be the `true` or the symbol from the component context.
ivanwonder
force-pushed
the
global-autocomplete-when-re-edit-symbol
branch
from
3ddbaf9
to
88842a0
Compare
atscott
approved these changes
Aug 2, 2021
atscott
added
target: rc
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
TeriGlover
added a commit
to TeriGlover/angular
that referenced
this issue
Sep 16, 2021
… tries to modify the symbol (angular#42923) When the user tries to trigger suggestions from an interruption, the LS should provide the global completions. For example, `[input]="t¦"`, the `t` can be the `true` or the symbol from the component context. PR Close angular#42923
TeriGlover
added a commit
to TeriGlover/angular
that referenced
this issue
Sep 22, 2021
… tries to modify the symbol (angular#42923) When the user tries to trigger suggestions from an interruption, the LS should provide the global completions. For example, `[input]="t¦"`, the `t` can be the `true` or the symbol from the component context. PR Close angular#42923
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
… tries to modify the symbol
When the user tries to trigger suggestions from an interruption,
the LS should provide the global completions. For example,
[input]="t¦", thetcan be thetrueor the symbol fromthe component context.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information