Skip to content

Issue form template#8565

Merged
ramyaparimi merged 3 commits into
mainfrom
issue-form-template
Aug 4, 2021
Merged

Issue form template#8565
ramyaparimi merged 3 commits into
mainfrom
issue-form-template

Conversation

@ramyaparimi
Copy link
Copy Markdown
Contributor

@ramyaparimi ramyaparimi commented Jul 26, 2021

Why:

Issue forms for creating new issues in OS repo

What's being changed:

Converted .md files to .yml issue forms

Check off the following:

  • I have reviewed my changes in staging (look for the latest deployment event in your pull request's timeline, then click View deployment).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@ramyaparimi ramyaparimi requested a review from janiceilene July 26, 2021 17:49
@ramyaparimi ramyaparimi requested a review from a team as a code owner July 26, 2021 17:49
@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Jul 26, 2021
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are:
.github/actions-scripts/**
.github/workflows/**
.github/CODEOWNERS
assets/fonts/**
data/graphql/**
lib/graphql/**
lib/redirects/**
lib/rest/**
lib/webhooks/**
scripts/**
translations/**
package*.json
app.json
Procfile

You'll need to revert all of the files you changed in that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team and removed triage Do not begin working on this issue until triaged by the team labels Jul 26, 2021
Comment thread .gitignore Outdated
@heiskr
Copy link
Copy Markdown
Contributor

heiskr commented Jul 26, 2021

npm ci; npm run prettier should get your build green

heiskr
heiskr previously approved these changes Jul 26, 2021
Comment thread .github/ISSUE_TEMPLATE/improve-existing-docs.yaml Outdated
Comment thread .github/ISSUE_TEMPLATE/improve-existing-docs.yaml Outdated
Comment thread .github/ISSUE_TEMPLATE/improve-existing-docs.yaml
Comment thread .github/ISSUE_TEMPLATE/improve-existing-docs.yaml Outdated
Comment thread .gitignore
@lee-dohm
Copy link
Copy Markdown
Contributor

If you're converting from Markdown issue templates to YAML issue templates, this PR should also delete the Markdown versions.

@ramyaparimi
Copy link
Copy Markdown
Contributor Author

ramyaparimi commented Jul 28, 2021

@lee-dohm Thanks for the review and suggestions! I made the changes suggested to all the issue forms, and I also created an issue form for Partner Program. Could you please give another look at changes I made? 🙇‍♀️

Comment thread .github/ISSUE_TEMPLATE/improve-existing-docs.yaml Outdated
Comment thread .github/ISSUE_TEMPLATE/improve-existing-docs.yaml Outdated
Comment thread .github/ISSUE_TEMPLATE/improve-existing-docs.yaml Outdated
Comment thread .github/ISSUE_TEMPLATE/improve-existing-docs.yaml Outdated
@@ -0,0 +1,49 @@
name: Improve existing content
description: Make a suggestion to improve the content in an existing article
title: '[What I really want the title to be]'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that title is a required field, is it? Can we just leave this out?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea I agree! I had the same question while writing the other two forms as well. Can we leave it out in the other two forms as well?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted the title key

Comment thread .github/ISSUE_TEMPLATE/improve-existing-docs.yaml Outdated
@lee-dohm
Copy link
Copy Markdown
Contributor

I have some significant questions about the intent of the Partner Program issue template. Can you remove it from this PR and open a separate PR for it?

@ramyaparimi
Copy link
Copy Markdown
Contributor Author

I have some significant questions about the intent of the Partner Program issue template. Can you remove it from this PR and open a separate PR for it?

Alright! Will do

@ramyaparimi ramyaparimi mentioned this pull request Jul 28, 2021
5 tasks
@ramyaparimi
Copy link
Copy Markdown
Contributor Author

I have some significant questions about the intent of the Partner Program issue template. Can you remove it from this PR and open a separate PR for it?

Here is the PR #8618

@ramyaparimi
Copy link
Copy Markdown
Contributor Author

@lee-dohm Is this now ready to ship? 😄

lee-dohm
lee-dohm previously approved these changes Jul 29, 2021
Copy link
Copy Markdown
Contributor

@lee-dohm lee-dohm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

One final change you should make before merging is removing the deletion of the partner-contributed-documentation.md file from this PR 😀

@ramyaparimi ramyaparimi dismissed a stale review via 2768288 August 2, 2021 16:47
lee-dohm
lee-dohm previously approved these changes Aug 2, 2021
Copy link
Copy Markdown
Contributor

@lee-dohm lee-dohm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ramyaparimi
Copy link
Copy Markdown
Contributor Author

@heiskr thank you for helping me with getting the build green ✨
@lee-dohm Thanks so much for taking time to review and give feedback on this PR 💜 Merging it now

@ramyaparimi ramyaparimi enabled auto-merge August 2, 2021 16:59
@ramyaparimi ramyaparimi added the ready to merge This pull request is ready to merge label Aug 2, 2021
@lee-dohm lee-dohm force-pushed the issue-form-template branch from 235902e to a3eff2b Compare August 3, 2021 20:01
@lee-dohm lee-dohm dismissed github-actions[bot]’s stale review August 3, 2021 20:03

Because we rewrote the entire history to take care of this problem 😀

@ramyaparimi
Copy link
Copy Markdown
Contributor Author

@lee-dohm Thank you for helping me with resolving the issues in this PR 💖 It was a ton of helpful knowledge 😀 ✨

Copy link
Copy Markdown
Contributor

@lee-dohm lee-dohm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@ramyaparimi ramyaparimi merged commit be743aa into main Aug 4, 2021
@ramyaparimi ramyaparimi deleted the issue-form-template branch August 4, 2021 16:50
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 4, 2021

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants