Issue form template#8565
Conversation
There was a problem hiding this comment.
👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are:
.github/actions-scripts/**
.github/workflows/**
.github/CODEOWNERS
assets/fonts/**
data/graphql/**
lib/graphql/**
lib/redirects/**
lib/rest/**
lib/webhooks/**
scripts/**
translations/**
package*.json
app.json
Procfile
You'll need to revert all of the files you changed in that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. ![]()
|
|
|
If you're converting from Markdown issue templates to YAML issue templates, this PR should also delete the Markdown versions. |
|
@lee-dohm Thanks for the review and suggestions! I made the changes suggested to all the issue forms, and I also created an issue form for Partner Program. Could you please give another look at changes I made? 🙇♀️ |
| @@ -0,0 +1,49 @@ | |||
| name: Improve existing content | |||
| description: Make a suggestion to improve the content in an existing article | |||
| title: '[What I really want the title to be]' | |||
There was a problem hiding this comment.
I don't think that title is a required field, is it? Can we just leave this out?
There was a problem hiding this comment.
Yea I agree! I had the same question while writing the other two forms as well. Can we leave it out in the other two forms as well?
There was a problem hiding this comment.
Deleted the title key
|
I have some significant questions about the intent of the Partner Program issue template. Can you remove it from this PR and open a separate PR for it? |
Alright! Will do |
Here is the PR #8618 |
|
@lee-dohm Is this now ready to ship? 😄 |
lee-dohm
left a comment
There was a problem hiding this comment.
Looks great!
One final change you should make before merging is removing the deletion of the partner-contributed-documentation.md file from this PR 😀
235902e to
a3eff2b
Compare
Because we rewrote the entire history to take care of this problem 😀
|
@lee-dohm Thank you for helping me with resolving the issues in this PR 💖 It was a ton of helpful knowledge 😀 ✨ |
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
Issue forms for creating new issues in OS repo
What's being changed:
Converted .md files to .yml issue forms
Check off the following:
Writer impact (This section is for GitHub staff members only):