Skip to content

Update creating-a-composite-run-steps-action.md#8253

Closed
KeisukeShima wants to merge 1 commit into
github:mainfrom
KeisukeShima:patch-2
Closed

Update creating-a-composite-run-steps-action.md#8253
KeisukeShima wants to merge 1 commit into
github:mainfrom
KeisukeShima:patch-2

Conversation

@KeisukeShima
Copy link
Copy Markdown

@KeisukeShima KeisukeShima commented Jul 15, 2021

Why:

I added it because there is no description about private action only in the Composite action document.

What's being changed:

Check off the following:

  • I have reviewed my changes in staging (look for the latest deployment event in your pull request's timeline, then click View deployment).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

I added it because there is no description about private action only in the Composite action document.
@welcome
Copy link
Copy Markdown

welcome Bot commented Jul 15, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Jul 15, 2021
@ramyaparimi
Copy link
Copy Markdown
Contributor

@KeisukeShima Thanks so much for opening a PR! I'll get this triaged for review ⚡

@ramyaparimi ramyaparimi added actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Jul 15, 2021
@KeisukeShima
Copy link
Copy Markdown
Author

@ramyaparimi Thanks for your comment.

Let me explain this PR.
Below are links to testing Javascript Action and Docker Action.
There are Private Action and Public Action in these, and the user can choose either one.
However, the Composite Action documentation does not have this description, and users may misunderstand that they cannot choose Private Action.
In fact, I also read the docs and thought that Composite Action couldn't create a Private Action.
However, in reality, any Action can be tested in the same way. Therefore, the appearance of the document should be the same.

https://docs.github.com/en/actions/creating-actions/creating-a-docker-container-action#testing-out-your-action-in-a-workflow
https://docs.github.com/en/actions/creating-actions/creating-a-javascript-action#testing-out-your-action-in-a-workflow

@KeisukeShima
Copy link
Copy Markdown
Author

I'm not a native English speaker, so corrections are welcome.

@janiceilene
Copy link
Copy Markdown
Contributor

👋 Thanks so much for this PR @KeisukeShima! There was a lot of work recently done on the composite actions docs. Let us know if the information you're looking for isn't in the new docs!

We appreciate your interest and passion in improving the GitHub docs 💖

@KeisukeShima KeisukeShima deleted the patch-2 branch September 15, 2021 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants