align ClassStaticBlockDeclaration with IIFE in CFA #44969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zzzen
reviewed
Jul 10, 2021
| !hasSyntacticModifier(node, ModifierFlags.Async) && | ||
| !(node as FunctionLikeDeclaration).asteriskToken && | ||
| !!getImmediatelyInvokedFunctionExpression(node)) || | ||
| node.kind === SyntaxKind.ClassStaticBlockDeclaration; |
There was a problem hiding this comment.
I am not sure how to format these lines, so here is how prettier handles it.
There was a problem hiding this comment.
I would have done it slightly differently, but prettier's format is fine.
sandersn
approved these changes
Aug 2, 2021
src/compiler/binder.ts
Outdated
| @@ -657,19 +657,23 @@ namespace ts { | |||
| const saveExceptionTarget = currentExceptionTarget; | |||
| const saveActiveLabelList = activeLabelList; | |||
| const saveHasExplicitReturn = hasExplicitReturn; | |||
| const isIIFE = containerFlags & ContainerFlags.IsFunctionExpression && !hasSyntacticModifier(node, ModifierFlags.Async) && | |||
| !(node as FunctionLikeDeclaration).asteriskToken && !!getImmediatelyInvokedFunctionExpression(node); | |||
| const isIIFELike = | |||
There was a problem hiding this comment.
Suggested change
| const isIIFELike = | |
| const isImmediatelyInvoked = |
(or isImmediate for even more old-school flavor)
| !hasSyntacticModifier(node, ModifierFlags.Async) && | ||
| !(node as FunctionLikeDeclaration).asteriskToken && | ||
| !!getImmediatelyInvokedFunctionExpression(node)) || | ||
| node.kind === SyntaxKind.ClassStaticBlockDeclaration; |
There was a problem hiding this comment.
I would have done it slightly differently, but prettier's format is fine.
|
Hi! I just left a new test case at the issue which you might want to check! Would be awesome if that case was covered by your fix, too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fixes #44949
The text was updated successfully, but these errors were encountered: