Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-42095: plistlib: Add tests that compare with plutil(1) #27173

Merged
merged 2 commits into from Jul 17, 2021
Merged

bpo-42095: plistlib: Add tests that compare with plutil(1) #27173

merged 2 commits into from Jul 17, 2021

Conversation

AliyevH
Copy link
Contributor

@AliyevH AliyevH commented Jul 15, 2021 •
edited by bedevere-bot

@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Jul 15, 2021
nanjekyejoannah
nanjekyejoannah reviewed Jul 15, 2021
View changes
Copy link
Member

@nanjekyejoannah nanjekyejoannah left a comment

Is there a reason why you created a new test file instead of adding the tests in Lib/test/test_plistlib.py?

@AliyevH
Copy link
Contributor Author

AliyevH commented Jul 15, 2021

@nanjekyejoannah in general no, there is no any reason.

@nanjekyejoannah
Copy link
Member

nanjekyejoannah commented Jul 16, 2021

@nanjekyejoannah in general no, there is no any reason.

Then just put the tests in Lib/test/test_plistlib.py rather than creating a new file . I will ping @ronaldoussoren for a review too.

@AliyevH AliyevH requested a review from nanjekyejoannah Jul 16, 2021
@ambv ambv merged commit 689b05c into python:main Jul 17, 2021
13 checks passed
@bedevere-bot
Copy link

bedevere-bot commented Jul 17, 2021

@ambv: Please replace # with GH- in the commit message next time. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanjekyejoannah nanjekyejoannah

Assignees
No one assigned
Labels
tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@AliyevH @nanjekyejoannah @bedevere-bot @ambv @the-knights-who-say-ni