Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-44563: Fix error handling in tee.fromiterable() #27020

Merged
merged 2 commits into from Jul 5, 2021
Merged

bpo-44563: Fix error handling in tee.fromiterable() #27020

merged 2 commits into from Jul 5, 2021

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jul 4, 2021 •
edited by bedevere-bot

In debug build failed tee.fromiterable() corrupted the linked
list of all GC objects.

https://bugs.python.org/issue44563

@serhiy-storchaka
bpo-44563: Fix error handling in tee.fromiterable()
4d61d1f 
In debug build failed tee.fromiterable() corrupted the linked
list of all GC objects.
pablogsal
pablogsal reviewed Jul 4, 2021
View changes
Modules/itertoolsmodule.c Outdated Show resolved Hide resolved
@pablogsal pablogsal merged commit f64de53 into python:main Jul 5, 2021
12 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Jul 5, 2021

Thanks @serhiy-storchaka for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Jul 5, 2021

GH-27041 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 5, 2021
@serhiy-storchaka @miss-islington
bpo-44563: Fix error handling in tee.fromiterable() (pythonGH-27020)
10a50ec 
In debug build failed tee.fromiterable() corrupted the linked list of all GC objects.
(cherry picked from commit f64de53)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 5, 2021
@serhiy-storchaka @miss-islington
bpo-44563: Fix error handling in tee.fromiterable() (pythonGH-27020)
f1e3824 
In debug build failed tee.fromiterable() corrupted the linked list of all GC objects.
(cherry picked from commit f64de53)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Jul 5, 2021

GH-27042 is a backport of this pull request to the 3.9 branch.

pablogsal pushed a commit that referenced this pull request Jul 5, 2021
@miss-islington @serhiy-storchaka
bpo-44563: Fix error handling in tee.fromiterable() (GH-27020) (GH-27042
324b932 
)

In debug build failed tee.fromiterable() corrupted the linked list of all GC objects.
(cherry picked from commit f64de53)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
pablogsal pushed a commit that referenced this pull request Jul 5, 2021
@miss-islington @serhiy-storchaka
bpo-44563: Fix error handling in tee.fromiterable() (GH-27020) (GH-27041
645e527 
)

In debug build failed tee.fromiterable() corrupted the linked list of all GC objects.
(cherry picked from commit f64de53)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Jul 6, 2021

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86 Gentoo Non-Debug with X 3.9 has failed when building commit 324b932.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/51/builds/117) and take a look at the build logs.
  4. Check if the failure is related to this commit (324b932) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/51/builds/117

Failed tests:

  • test_codecmaps_kr
  • test_urllibnet

Failed subtests:

  • test_mapping_file - test.test_codecmaps_kr.TestJOHABMap
  • test_data_header - test.test_urllibnet.urlretrieveNetworkTests
  • test_geturl - test.test_urllibnet.urlopenNetworkTests
  • test_mapping_file - test.test_codecmaps_kr.TestCP949Map
  • test_getcode - test.test_urllibnet.urlopenNetworkTests
  • test_reporthook - test.test_urllibnet.urlretrieveNetworkTests
  • test_mapping_file - test.test_codecmaps_kr.TestEUCKRMap

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

415 tests OK.

10 slowest tests:

  • test_peg_generator: 12 min 41 sec
  • test_concurrent_futures: 4 min 41 sec
  • test_unparse: 3 min 21 sec
  • test_lib2to3: 3 min 17 sec
  • test_multiprocessing_spawn: 3 min 3 sec
  • test_asyncio: 2 min 59 sec
  • test_tokenize: 2 min 47 sec
  • test_urllib2: 2 min 1 sec
  • test_multiprocessing_forkserver: 1 min 42 sec
  • test_urllibnet: 1 min 36 sec

1 test failed:
test_codecmaps_kr

9 tests skipped:
test_devpoll test_ioctl test_kqueue test_msilib test_startfile
test_winconsoleio test_winreg test_winsound test_zipfile64

2 re-run tests:
test_codecmaps_kr test_urllibnet

Total duration: 43 min 13 sec

Click to see traceback logs 
Traceback (most recent call last):
  File "/buildbot/buildarea/cpython/3.9.ware-gentoo-x86.nondebug/build/Lib/test/test_urllibnet.py", line 210, in test_reporthook
    expected_size = int(fileheaders['Content-Length'])
TypeError: int() argument must be a string, a bytes-like object or a number, not 'NoneType'


Traceback (most recent call last):
  File "/buildbot/buildarea/cpython/3.9.ware-gentoo-x86.nondebug/build/Lib/test/test_urllibnet.py", line 97, in test_geturl
    self.assertEqual(gotten_url, self.url)
AssertionError: 'http://192.168.1.254/cgi-bin/autodetect.ha' != 'http://www.pythontest.net/'
- http://192.168.1.254/cgi-bin/autodetect.ha
+ http://www.pythontest.net/


Traceback (most recent call last):
  File "/buildbot/buildarea/cpython/3.9.ware-gentoo-x86.nondebug/build/Lib/test/test_urllibnet.py", line 198, in test_data_header
    time.strptime(datevalue, dateformat)
  File "/buildbot/buildarea/cpython/3.9.ware-gentoo-x86.nondebug/build/Lib/_strptime.py", line 562, in _strptime_time
    tt = _strptime(data_string, format)[0]
  File "/buildbot/buildarea/cpython/3.9.ware-gentoo-x86.nondebug/build/Lib/_strptime.py", line 317, in _strptime
    raise TypeError(msg.format(index, type(arg)))
TypeError: strptime() argument 0 must be str, not <class 'NoneType'>


Traceback (most recent call last):
  File "/buildbot/buildarea/cpython/3.9.ware-gentoo-x86.nondebug/build/Lib/test/multibytecodec_support.py", line 305, in test_mapping_file
    self._test_mapping_file_plain()
  File "/buildbot/buildarea/cpython/3.9.ware-gentoo-x86.nondebug/build/Lib/test/multibytecodec_support.py", line 322, in _test_mapping_file_plain
    self.fail(f"Invalid line: {line!r}")
AssertionError: Invalid line: '        <title>Not Found</title>\n'


Traceback (most recent call last):
  File "/buildbot/buildarea/cpython/3.9.ware-gentoo-x86.nondebug/build/Lib/test/test_urllibnet.py", line 109, in test_getcode
    self.assertEqual(code, 404)
AssertionError: 200 != 404

@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhettinger rhettinger

@pablogsal pablogsal

Assignees
No one assigned
Labels
skip news type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@serhiy-storchaka @miss-islington @bedevere-bot @rhettinger @pablogsal @the-knights-who-say-ni