Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ephemeral iOS directory to put future generated files #76830

Merged
merged 2 commits into from Feb 26, 2021

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Feb 25, 2021

Future prevention of #39491 on iOS. There's nothing currently generated in this ephemeral directory, but I'm about to put out a PR that will generate a few files to this location.

  • Rename iOS module directory property ephemeralDirectory -> ephemeralModuleDirectory
  • Create a project property for Flutter/ephemeral directory.
  • Remove the ephemeralDirectory on flutter clean
  • Add to .gitignore

This doesn't actually move any existing generated files to this location--that can be done in individual follow-up PRs as needed.

@@ -18,6 +18,7 @@ Flutter/App.framework
Flutter/Flutter.framework
Flutter/Flutter.podspec
Flutter/Generated.xcconfig
Flutter/ephemeral/

This comment has been minimized.

@jmagman

jmagman Feb 25, 2021
Author Member

\cc @RedBrogdon Sorry here's another directory to add to all the iOS sample .gitignores. But new ones should be rare in the future with this PR.

@jmagman jmagman requested review from jonahwilliams and stuartmorgan Feb 25, 2021
Copy link
Member

@jonahwilliams jonahwilliams left a comment

LGTM

@jmagman
Copy link
Member Author

@jmagman jmagman commented Feb 25, 2021

Sorry here's another directory to add to all the iOS sample .gitignores. But new ones should be rare in the future with this PR.

Oh that reminds me, better do the same for the examples/integration_tests in this repo...

@@ -92,6 +92,7 @@ unlinked_spec.ds
**/ios/Flutter/Flutter.framework
**/ios/Flutter/Flutter.podspec
**/ios/Flutter/Generated.xcconfig
**/ios/Flutter/ephemeral

This comment has been minimized.

@jmagman

jmagman Feb 25, 2021
Author Member

The other non-template .gitignores aren't necessary on top of this one, but let's be consistent.

Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Nice, LGTM!

Apologies for the naming collision; I didn't realize there was already something called "the ephemeral directory" when I made this concept for desktop, and by the time I realized it would have been a giant pain to change.

@jmagman
Copy link
Member Author

@jmagman jmagman commented Feb 26, 2021

Apologies for the naming collision

Naming is hard. "modules" also references several concepts. 😄

@fluttergithubbot fluttergithubbot merged commit d099ae6 into flutter:master Feb 26, 2021
76 checks passed
76 checks passed
@flutter-github-sync
Google testing Google testing passed!
Details
@flutter-dashboard
Linux analyze
Details
@flutter-dashboard
Linux build_aar_module_test
Details
@flutter-dashboard
Linux build_tests
Details
@flutter-dashboard
Linux customer_testing
Details
@flutter-dashboard
Linux docs
Details
@flutter-dashboard
Linux firebase_abstract_method_smoke_test
Details
@flutter-dashboard
Linux firebase_android_embedding_v2_smoke_test
Details
@flutter-dashboard
Linux firebase_release_smoke_test
Details
@flutter-dashboard
Linux flutter_plugins
Details
@flutter-dashboard
Linux framework_tests
Details
@flutter-dashboard
Linux fuchsia_precache
Details
@flutter-dashboard
Linux gradle_desugar_classes_test
Details
@flutter-dashboard
Linux gradle_non_android_plugin_test
Details
@flutter-dashboard
Linux gradle_plugin_bundle_test
Details
@flutter-dashboard
Linux gradle_plugin_fat_apk_test
Details
@flutter-dashboard
Linux gradle_plugin_light_apk_test
Details
@flutter-dashboard
Linux module_custom_host_app_name_test
Details
@flutter-dashboard
Linux module_host_with_custom_build_test
Details
@flutter-dashboard
Linux module_test
Details
@flutter-dashboard
Linux plugin_test
Details
@flutter-dashboard
Linux tool_integration_tests
Details
@flutter-dashboard
Linux tool_tests
Details
@flutter-dashboard
Linux web_benchmarks_html
Details
@flutter-dashboard
Linux web_e2e_test
Details
@flutter-dashboard
Linux web_integration_tests
Details
@flutter-dashboard
Linux web_long_running_tests
Details
@flutter-dashboard
Linux web_smoke_test
Details
@flutter-dashboard
Linux web_tests
Details
@flutter-dashboard
Linux web_tool_tests
Details
@flutter-dashboard
Mac build_aar_module_test
Details
@flutter-dashboard
Mac build_ios_framework_module_test
Details
@flutter-dashboard
Mac build_tests
Details
@flutter-dashboard
Mac customer_testing
Details
@flutter-dashboard
Mac dart_plugin_registry_test
Details
@flutter-dashboard
Mac framework_tests
Details
@flutter-dashboard
Mac gradle_non_android_plugin_test
Details
@flutter-dashboard
Mac gradle_plugin_bundle_test
Details
@flutter-dashboard
Mac gradle_plugin_fat_apk_test
Details
@flutter-dashboard
Mac gradle_plugin_light_apk_test
Details
@flutter-dashboard
Mac module_custom_host_app_name_test
Details
@flutter-dashboard
Mac module_host_with_custom_build_test
Details
@flutter-dashboard
Mac module_test
Details
@flutter-dashboard
Mac module_test_ios
Details
@flutter-dashboard
Mac plugin_lint_mac
Details
@flutter-dashboard
Mac plugin_test
Details
@flutter-dashboard
Mac tool_integration_tests
Details
@flutter-dashboard
Mac tool_tests
Details
@flutter-dashboard
Mac web_tool_tests
Details
@wip
WIP Ready for review
Details
@flutter-dashboard
Windows build_aar_module_test
Details
@flutter-dashboard
Windows build_tests
Details
@flutter-dashboard
Windows customer_testing
Details
@flutter-dashboard
Windows framework_tests
Details
@flutter-dashboard
Windows gradle_non_android_plugin_test
Details
@flutter-dashboard
Windows gradle_plugin_bundle_test
Details
@flutter-dashboard
Windows gradle_plugin_light_apk_test
Details
@flutter-dashboard
Windows module_custom_host_app_name_test
Details
@flutter-dashboard
Windows module_host_with_custom_build_test
Details
@flutter-dashboard
Windows module_test
Details
@flutter-dashboard
Windows plugin_test
Details
@flutter-dashboard
Windows tool_integration_tests
Details
@flutter-dashboard
Windows tool_tests
Details
@cirrus-ci
analyze-linux Task Summary
Details
@google-cla
cla/google All necessary CLAs are signed
@cirrus-ci
customer_testing-linux Task Summary
Details
@cirrus-ci
docs-linux Task Summary
Details
@flutter-dashboard
flutter-build Flutter build is currently broken. Please do not merge this PR unless it contains a fix to the broken build.
Details
@flutter-dashboard
flutter-gold All golden file tests have passed.
Details
@cirrus-ci
framework_tests-libraries-linux Task Summary
Details
@cirrus-ci
framework_tests-misc-linux Task Summary
Details
@cirrus-ci
framework_tests-widgets-linux Task Summary
Details
@cirrus-ci
tool_tests-commands-linux Task Summary
Details
@cirrus-ci
tool_tests-general-linux Task Summary
Details
@cirrus-ci
web_integration_tests Task Summary
Details
@cirrus-ci
web_smoke_test Task Summary
Details
@jmagman jmagman deleted the jmagman:ephemeral branch Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants