Python: Promote shared type tracking library#6063
Merged
Merged
Conversation
This was slightly messier than anticipated, as I hadn't accounted for the dozen uses of `startInAttr` in our codebase. To circumvent this, I decided to put the type tracking implementation in the `internal` directory, and wrap it with a file that ensures the old interface still works.
RasmusWL
approved these changes
Jun 14, 2021
RasmusWL
left a comment
RasmusWL
left a comment
Member
There was a problem hiding this comment.
Besides performance, this change looks good to me 👍
Contributor
Author
|
Ah yes, performance. Here are the numbers: https://github.com/dsp-testing/tausbn-dca/tree/run/python-promote-type-tracker/reports Not obviously better (or worse, for that matter), but I think it's likely that this only really makes a difference on very large projects. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was slightly messier than anticipated, as I hadn't accounted for
the dozen uses of
startInAttrin our codebase. To circumvent this,I decided to put the type tracking implementation in the
internaldirectory, and wrap it with a file that ensures the old interface still
works.
No change note required as the interface didn't change.
Before merging, I intend to run a test to see how the refactoring added by hvitved affects performance. It should (hopefully) only make it faster.