Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python*: remove tcl-tk option. #34424

Merged
merged 2 commits into from Nov 25, 2018
Merged

python*: remove tcl-tk option. #34424

merged 2 commits into from Nov 25, 2018
+0 −109

Conversation

@MikeMcQuaid
Copy link
Member

@MikeMcQuaid MikeMcQuaid commented Nov 24, 2018 •
edited

This is based on their brew info --analytics usage and build errors.

Additionally, this removes two patches that aren't going upstream.

Part of #31510.

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?
MikeMcQuaid added 2 commits Nov 24, 2018
@MikeMcQuaid
python@2: remove tcl-tk option.
6f6e765
@MikeMcQuaid
python: remove tcl-tk option.
876e1c1
@MikeMcQuaid MikeMcQuaid changed the title This is based on their brew info --analytics usage and build errors. python*: remove tcl-tk option. Nov 24, 2018
@MikeMcQuaid MikeMcQuaid merged commit a377978 into Homebrew:master Nov 25, 2018
1 check failed
@MikeMcQuaid MikeMcQuaid deleted the python-remove-tcl-tk-option branch Nov 25, 2018
@lock lock bot added the outdated label Dec 25, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Dec 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fxcoudert fxcoudert

Assignees
No one assigned
Labels
outdated
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@MikeMcQuaid @fxcoudert