Skip to content

/ Java

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplified program #964

Open
wants to merge 3 commits into
base: master
from
Open

simplified program #964

wants to merge 3 commits into from

Conversation

@yatin9988
Copy link

@yatin9988 yatin9988 commented Oct 4, 2019

removed uneccessary conditions.
@yatin9988
simplified program
539828a
@Spikatrix
Copy link
Contributor

@Spikatrix Spikatrix commented Oct 6, 2019

Your code is flawed as it returns the function will return true for n <= 1
yatin9988 added 2 commits Oct 6, 2019
@yatin9988
now works for value less than 1 as well
33aa174
@yatin9988
Merge branch 'master' into primeCheck
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
6615902
@Spikatrix
Spikatrix reviewed Oct 6, 2019
View changes
Copy link
Contributor

@Spikatrix Spikatrix left a comment

Looks to be correct now, but the previous code is more efficient and well structured.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Spikatrix Spikatrix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@yatin9988 @Spikatrix
You can’t perform that action at this time.