Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd class MillisBpmConverter #1100
Open
Conversation
Update fork with latest commits of upstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
I added class MillisBpmConverter, that handles the conversion between units of measure for time intervals. These units of measure are Beats Per Minute (BPM) and the milliseconds between two beats (two quarter notes to be precise).
This class contains three methods:
int millisToBpm(long millis)which converts a time interval expressed in milliseconds to a time interval expressed in beats per minute.long bpmToMillis(int bpm)which converts a time interval expressed in beats per minute to a time interval expressed in milliseconds.void main(String[] args)which is used to start the program and contains an example of usage for the class.Also I noticed and fixed an empty if statement inside class "Abecedarian". I know it's not my class, so if you want me to remove this "fix", please let me know.