Skip to content

/ grafana

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explore: Migrate from GrafanaTheme to GrafanaTheme2 #35097

Open
Elfo404 opened this issue Jun 2, 2021 · 2 comments
Open

Explore: Migrate from GrafanaTheme to GrafanaTheme2 #35097

Elfo404 opened this issue Jun 2, 2021 · 2 comments
Labels
Epic area/explore good first issue onboarding priority/important-soon

Comments

@Elfo404
Copy link
Contributor

@Elfo404 Elfo404 commented Jun 2, 2021

Multiple Explore-related components still make use of GrafanaTheme.
Since Grafana 8.0 introduces GrafanaTheme2 and deprecates GrafanaTheme we should migrate to the new theme.

This should probably be done in multiple small PRs that target a small amount of components to make review easy.

Also the following data sources have components that need to be migrated:

  • Elasticsearch
  • Loki
  • Graphite
  • Prometheus
@Betula-L
Copy link

@Betula-L Betula-L commented Jun 3, 2021

Can i take this up?
@torkelo
Copy link
Member

@torkelo torkelo commented Jun 3, 2021

I have not updated the theme guide nor created a migration guide (on my todo after v8). In the meantime this is a good guide how we translate the new theme to v1 theme:
https://github.com/grafana/grafana/blob/main/packages/grafana-data/src/themes/createV1Theme.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Epic area/explore good first issue onboarding priority/important-soon
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@torkelo @Elfo404 @Betula-L