Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tests to a single tests/ folder #290

Open
gdude2002 opened this issue Oct 20, 2019 · 3 comments
Open

Move tests to a single tests/ folder #290

gdude2002 opened this issue Oct 20, 2019 · 3 comments

Comments

@gdude2002
Copy link
Contributor

@gdude2002 gdude2002 commented Oct 20, 2019

As discussed on Discord, we currently have tests for each app placed within the app's directory - but this leaves us without a clean place to test things like utils, which aren't unique to the app.

Instead, all tests should be moved to pydis_site/tests, with a subfolder for each app - much like we did with the templates and static files.

@ju-sh
Copy link

@ju-sh ju-sh commented Oct 21, 2019

I'll give a shot at this.

@scragly
Copy link
Member

@scragly scragly commented Oct 21, 2019

This is still in active discussion and we're not yet decided if this is something we're going to do.

As a note for future @ju-sh, it's best to wait for a reply and to be assigned by an org member before going ahead with any PRs.

@gdude2002
Copy link
Contributor Author

@gdude2002 gdude2002 commented Oct 21, 2019

Sorry, that's my bad. I was given the go-ahead to apply the good first issue label before a discussion prompt came up, and I forgot to apply the discussion label at that point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.