Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-44089: Allow subclassing of csv.Error #26008

Merged
merged 2 commits into from May 12, 2021
Merged

bpo-44089: Allow subclassing of csv.Error #26008

merged 2 commits into from May 12, 2021

Conversation

@Fidget-Spinner
Copy link
Contributor

@Fidget-Spinner Fidget-Spinner commented May 9, 2021 •
edited by bedevere-bot

https://bugs.python.org/issue44089
@Fidget-Spinner Fidget-Spinner requested a review from encukou May 9, 2021
orsenthil
orsenthil approved these changes May 12, 2021
View changes
Copy link
Member

@orsenthil orsenthil left a comment

LGTM

@orsenthil orsenthil merged commit 2b458c1 into python:main May 12, 2021
12 checks passed
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented May 12, 2021

Thanks @Fidget-Spinner for the PR, and @orsenthil for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington added a commit to miss-islington/cpython that referenced this issue May 12, 2021
@Fidget-Spinner @miss-islington
bpo-44089: Allow subclassing of csv.Error (pythonGH-26008)
52d7868 
* fix subclass error

* Update 2021-05-09-22-52-34.bpo-44089.IoANsN.rst
(cherry picked from commit 2b458c1)

Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented May 12, 2021

GH-26066 is a backport of this pull request to the 3.10 branch.

orsenthil pushed a commit that referenced this issue May 12, 2021
@Fidget-Spinner @miss-islington
bpo-44089: Allow subclassing of csv.Error (GH-26008) (GH-26066)
3e44e9a 
* fix subclass error

* Update 2021-05-09-22-52-34.bpo-44089.IoANsN.rst
(cherry picked from commit 2b458c1)

Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>

Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>
@Fidget-Spinner Fidget-Spinner deleted the subclass-csv branch May 12, 2021
@Fidget-Spinner
Copy link
Contributor Author

@Fidget-Spinner Fidget-Spinner commented May 12, 2021

@orsenthil thank you for taking the time to review and merge!

@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orsenthil orsenthil

@JelleZijlstra JelleZijlstra

@encukou encukou

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
6 participants
@Fidget-Spinner @miss-islington @bedevere-bot @orsenthil @JelleZijlstra @the-knights-who-say-ni