bpo-44074: let patchcheck infer the base branch name #25991
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
Tools/scripts/patchcheck.py
Outdated
| """ | ||
| cmd = "git rev-parse --abbrev-ref {}".format(remote_name).split() | ||
| try: | ||
| full_name = subprocess.check_output(cmd, |
There was a problem hiding this comment.
Hummm, this may return something wrong depending on how you have the git setup. For instance, in my machine this gives:
❯ git rev-parse --abbrev-ref upstream
upstream/HEAD
There was a problem hiding this comment.
Thanks, I have changed the way the branch name is parsed, now it should be (hopefully) more reliable.
|
Wonderful, thanks a lot! |
|
Btw, can you sign the CLA as per this message: |
|
I have actually signed the CLA and received a copy by email, even though the checker website doesn't recognize it yet. It says to wait at least one business day to update their DB, otherwise I can manually forward the signed CLA document to whomever needs it. |
|
Thanks @leoll2 for the PR, and @pablogsal for merging it |
|
Thanks @leoll2 for the PR, and @pablogsal for merging it |
|
GH-26022 is a backport of this pull request to the 3.9 branch. |
(cherry picked from commit 21fbbb9) Co-authored-by: Leonardo Lai <leonardo.lai@live.com>
|
GH-26023 is a backport of this pull request to the 3.10 branch. |
https://bugs.python.org/issue44074