Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-31904: Correct error string in test_file_not_exists() for VxWorks #25965

Merged
merged 2 commits into from May 8, 2021
Merged

bpo-31904: Correct error string in test_file_not_exists() for VxWorks #25965

merged 2 commits into from May 8, 2021
+2 −1

Conversation

@pxinwr
Copy link
Contributor

@pxinwr pxinwr commented May 7, 2021 •
edited by miss-islington

The error string on VxWorks is "no such file or directory" for FileNotFoundError. That is, the 1st letter of the error string has lower case.

https://bugs.python.org/issue31904

Automerge-Triggered-By: GH:gpshead
@pxinwr
correct error string in test.test_py_compile.PyCompileCLITestCase.tes…
Loading status checks…
e264985 
…t_file_not_exists for VxWorks
@gpshead
gpshead reviewed May 7, 2021
View changes
Lib/test/test_py_compile.py Outdated Show resolved Hide resolved
@gpshead gpshead self-assigned this May 7, 2021
@pxinwr
ignore error string case in test_file_not_exists()
Loading status checks…
ed35684
@gpshead
gpshead approved these changes May 8, 2021
View changes
@miss-islington miss-islington merged commit b063b02 into python:main May 8, 2021
12 checks passed
12 checks passed
@github-actions
Docs
Details
@github-actions
Check for source changes
Details
@github-actions
Check if generated files are up to date
Details
@github-actions
Windows (x86)
Details
@github-actions
Windows (x64)
Details
@github-actions
macOS
Details
@github-actions
Ubuntu
Details
@github-actions
Ubuntu SSL tests with OpenSSL
Details
Azure Pipelines PR #20210508.14 succeeded
Details
@travis-ci
Travis CI - Pull Request Build Passed
Details
@bedevere-bot
bedevere/issue-number Issue number 31904 found
Details
@bedevere-bot
bedevere/news News entry found in Misc/NEWS.d
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented May 8, 2021

Thanks @pxinwr for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented May 8, 2021

GH-25983 is a backport of this pull request to the 3.10 branch.
miss-islington added a commit that referenced this pull request May 8, 2021
@miss-islington
[3.10] bpo-31904: Correct error string in test_file_not_exists() for …
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
6e7fe19 
…VxWorks (GH-25965) (GH-25983)

The error string on VxWorks is "no such file or directory" for FileNotFoundError. That is, the 1st letter of the error string has lower case.
(cherry picked from commit b063b02)


Co-authored-by: pxinwr <peixing.xin@windriver.com>

Automerge-Triggered-By: GH:gpshead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpshead gpshead

Assignees

@gpshead gpshead

Labels
🤖 automerge CLA signed type-tests
Projects
None yet
Milestone
No milestone
5 participants
@pxinwr @miss-islington @bedevere-bot @gpshead @the-knights-who-say-ni