Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-43997: Add versionadded directives for to match_args, kw_only, and slots in dataclasses.dataclasses documentation #25803

Merged
merged 4 commits into from May 2, 2021

Conversation

shreyanavigyan
Copy link
Contributor

@shreyanavigyan shreyanavigyan commented May 2, 2021

https://bugs.python.org/issue43997

Automerge-Triggered-By: GH:ericvsmith

@shreyanavigyan shreyanavigyan requested a review from ericvsmith as a code owner May 2, 2021
@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label May 2, 2021
@shreyanavigyan
Copy link
Contributor Author

shreyanavigyan commented May 2, 2021

Skip news

Copy link
Member

@ericvsmith ericvsmith left a comment

There's also the kw_only argument to field(). Can you add versionadded there?

@bedevere-bot
Copy link

bedevere-bot commented May 2, 2021

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@shreyanavigyan
Copy link
Contributor Author

shreyanavigyan commented May 2, 2021

I have made the requested changes; please review again

@bedevere-bot
Copy link

bedevere-bot commented May 2, 2021

Thanks for making the requested changes!

@ericvsmith: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from ericvsmith May 2, 2021
@ericvsmith ericvsmith added the 🤖 automerge PR will be merged once it's been approved and all CI passed label May 2, 2021
@miss-islington miss-islington merged commit a5eabc9 into python:master May 2, 2021
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir 🤖 automerge PR will be merged once it's been approved and all CI passed skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants