Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-17642: Add hotkeys to resize IDLE's font #17107

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ZackerySpytz
Copy link
Contributor

@ZackerySpytz ZackerySpytz commented Nov 11, 2019

The implementation is based on the font-resizing code in turtledemo.
Changing the font size with the hotkeys or the mouse wheel will not
modify the config setting.

https://bugs.python.org/issue17642

It will need to be refined later.
Copy link
Member

@terryjreedy terryjreedy left a comment

#6665 for bpo-33397 defines a FontSizer class in textview.py and uses it for textviews and the help viewer. I intend for it to be used everywhere for key/wheel font resizing, especially including editor windows. So as is, this PR duplicates the work there and needs to be either rewritten or replaced.

You could help by reviewing that code and testing it on your system, and even better, copying the new textview into your branch (or a new one) and trying to use it for the editor.

Editor font resizing must also change the context window if present and the line number window if present. There should be a function that does that, but it might be hard-coded to use the general config values.

Changing configdialog font sizing is bpo-24776. My latest plan for that (msg334281) is to use the font sizer (or subclass) to change both the font sample and the number is a box.

Copy link
Member

@terryjreedy terryjreedy left a comment

Whoops, hit wrong radiobutton.

@bedevere-bot
Copy link

bedevere-bot commented Nov 12, 2019

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@ZackerySpytz
Copy link
Contributor Author

ZackerySpytz commented Nov 14, 2019

Thank you, @terryjreedy, for commenting on this PR. I would certainly like to help with adding this feature to IDLE. I will take a look at the other PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants