Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-44042: sqlite3 begin transaction optimisations #25908

Merged
merged 9 commits into from Jun 3, 2021
Merged

bpo-44042: sqlite3 begin transaction optimisations #25908

merged 9 commits into from Jun 3, 2021

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented May 4, 2021 •
edited by bedevere-bot

https://bugs.python.org/issue44042
@erlend-aasland erlend-aasland requested a review from berkerpeksag as a code owner May 4, 2021
@erlend-aasland erlend-aasland changed the title bpo-44042: Begin transaction optimisations bpo-44042: sqlite3 begin transaction optimisations May 5, 2021
@erlend-aasland erlend-aasland force-pushed the erlend-aasland:sqlite-begin branch from 094e9b8 to c9d110e May 7, 2021
@erlend-aasland
Copy link
Contributor Author

@erlend-aasland erlend-aasland commented May 7, 2021

Changes are not user visible, so I'm adding the skip news label.
@erlend-aasland
_pysqlite_connection_begin() now returns an int
90bac9c
@erlend-aasland
Move _pysqlite_connection_begin to cursor.c
916db29
@erlend-aasland
Rename _pysqlite_connection_begin to begin_transaction
0f47667
@erlend-aasland
PEP 7
86d1ca0
@erlend-aasland
Defer error checking till post sqlite3_finalize()
891ebce 
Any errors will propagate.
@erlend-aasland erlend-aasland force-pushed the erlend-aasland:sqlite-begin branch from c9d110e to 891ebce May 7, 2021
@erlend-aasland
Simplify error handling
393368f
@erlend-aasland
erlend-aasland reviewed May 7, 2021
View changes
Modules/_sqlite/cursor.c Outdated Show resolved Hide resolved
@erlend-aasland
Copy link
Contributor Author

@erlend-aasland erlend-aasland commented May 8, 2021

cc. @corona10
@corona10
Copy link
Member

@corona10 corona10 commented May 9, 2021

@erlend-aasland

This is PR looks good to be labeled as skip news
@erlend-aasland
Revert "Simplify error handling"
4a7d9a1 
This reverts commit 393368f.
@erlend-aasland
Merge branch 'main' into sqlite-begin
2d28a2a
@erlend-aasland erlend-aasland requested a review from pablogsal Jun 3, 2021
@erlend-aasland
Reduce unneeded if nesting
5e64f35
@erlend-aasland erlend-aasland force-pushed the erlend-aasland:sqlite-begin branch from ff2893e to 5e64f35 Jun 3, 2021
@pablogsal
pablogsal approved these changes Jun 3, 2021
View changes
@pablogsal pablogsal merged commit 3446516 into python:main Jun 3, 2021
10 checks passed
10 checks passed
@github-actions
Check for source changes
Details
@github-actions
Check if generated files are up to date
Details
@github-actions
Windows (x86)
Details
@github-actions
Windows (x64)
Details
@github-actions
macOS
Details
@github-actions
Ubuntu
Details
@github-actions
Ubuntu SSL tests with OpenSSL
Details
@travis-ci
Travis CI - Pull Request Build Passed
Details
@bedevere-bot
bedevere/issue-number Issue number 44042 found
Details
@bedevere-bot
bedevere/news "skip news" label found
@erlend-aasland erlend-aasland deleted the erlend-aasland:sqlite-begin branch Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal

@berkerpeksag berkerpeksag

Assignees
No one assigned
Labels
CLA signed skip news
Projects
None yet
Milestone
No milestone
5 participants
@erlend-aasland @corona10 @pablogsal @the-knights-who-say-ni @bedevere-bot