bpo-28602: [WIP] Add fold support to fromutc #7425
Open
+65
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This is an example implementation of generic fold support in
datetime.fromutc, for purposes of discussion. The idea here is that so long asutcoffset - dstis constant (as is the fundamental assumption of the currentfromutcimplementation) and theutcoffsetanddstimplementations respect thefoldparameter, this will always set thefoldparameter correctly infromutc.This needs more extensive tests and a pure Python implementation (plus I don't think I was amazingly careful about the reference counts), but the overall outline is there. It's basically a port of the current base dateutil implementation.
https://bugs.python.org/issue28602
https://bugs.python.org/issue28602