[3.9] bpo-41129: Fix check for macOS SDK paths when building Python (GH-25785) #25830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…GH-25785) Narrow search to match contents of SDKs, namely only files in ``/System/Library``, ``/System/IOSSupport``, and ``/usr`` other than ``/usr/local``. Previously, anything under ``/System`` was assumed to be in an SDK which causes problems with the new file system layout in 10.15+ where user file systems may appear to be mounted under ``/System``. Paths in ``/Library`` were also incorrectly treated as SDK locations. Co-authored-by: Ned Deily <nad@python.org> (cherry picked from commit d52bbde) Co-authored-by: Ned Batchelder <ned@nedbatchelder.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Narrow search to match contents of SDKs, namely only files in
/System/Library,/System/IOSSupport, and/usrother than/usr/local. Previously,anything under
/Systemwas assumed to be in an SDK which causes problemswith the new file system layout in 10.15+ where user file systems may appear
to be mounted under
/System. Paths in/Librarywere alsoincorrectly treated as SDK locations.
Co-authored-by: Ned Deily nad@python.org
(cherry picked from commit d52bbde)
Co-authored-by: Ned Batchelder ned@nedbatchelder.com
https://bugs.python.org/issue41129