Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make clear when too slow for lane changes #20565

Open
HaraldSchafer opened this issue Apr 2, 2021 · 8 comments · May be fixed by #20572
Open

Make clear when too slow for lane changes #20565

HaraldSchafer opened this issue Apr 2, 2021 · 8 comments · May be fixed by #20572

Comments

@HaraldSchafer
Copy link
Contributor

@HaraldSchafer HaraldSchafer commented Apr 2, 2021

If you command a lane change under 45mph, nothing will happen. It it should be clear to the user that no lane change can be done because the speed is too low.

Perhaps instead of the message "Steer Left to Start Lane Change" that appears above 45mph something like "Speed too low for lane change"

@VirtuallyChris
Copy link
Contributor

@VirtuallyChris VirtuallyChris commented Apr 2, 2021

Maybe we can make a way to show this with an icon or something similar. I feel like an alert would be distracting every time I turn my blinker on under 45mph.

@adeebshihadeh
Copy link
Contributor

@adeebshihadeh adeebshihadeh commented Apr 2, 2021

I think a small, one-line alert with no sound should be fine.

@VirtuallyChris
Copy link
Contributor

@VirtuallyChris VirtuallyChris commented Apr 2, 2021

True, 1 line alert would be okay

@Winvoker
Copy link

@Winvoker Winvoker commented Apr 3, 2021

I was looking to solve this , however I saw that, it is already implemented something like this. Doesn't this function does what you were saying.

def below_steer_speed_alert(CP: car.CarParams, sm: messaging.SubMaster, metric: bool) -> Alert:

It is called at :

EventName.belowSteerSpeed: {

The alert was already implemented. I added new state to check if it is below min speed.

@Winvoker Winvoker linked a pull request that will close this issue Apr 3, 2021
@advcu987
Copy link

@advcu987 advcu987 commented Apr 3, 2021

I saw the unit tests fail for this PR, doesn't the belowSpeed field need to be added to the LaneChangeState enum in openpilot/cereal/log.capnp?

  enum LaneChangeState {
    off @0;
    preLaneChange @1;
    laneChangeStarting @2;
    laneChangeFinishing @3;
    belowSpeed @4
;  }

@Winvoker
Copy link

@Winvoker Winvoker commented Apr 3, 2021

I saw the unit tests fail for this PR, doesn't the belowSpeed field need to be added to the LaneChangeState enum in openpilot/cereal/log.capnp?

  enum LaneChangeState {
    off @0;
    preLaneChange @1;
    laneChangeStarting @2;
    laneChangeFinishing @3;
    belowSpeed @4
;  }

Thank you sir ! I was looking for this. I created a PR for cereal. commaai/cereal#129

@cydia2020
Copy link
Contributor

@cydia2020 cydia2020 commented Apr 4, 2021

Is this something that you would be interested in? (Displaying a small lane change ready icon if the desired conditions are reached (enabled + vego > 20) I will make this easier to see if you give the go.
16175243712658387174686061597140

Edit:
Anyway this is something that I planned to add quite a while ago, so this is what I'm thinking it would look like. (Ignore the other icons on the screen, just the small ready icon in the upper right corner)
16175252248636815579003827633538

@pd0wm
Copy link
Contributor

@pd0wm pd0wm commented May 3, 2021

@HaraldSchafer Do you think this is still an issue now that the lane change speed is lowered?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

7 participants