Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upsimplify #1
Merged
simplify #1
Conversation
methane
force-pushed the
methane:expand-news-entries-sphinx
branch
from
6fd8a0b
to
b13ca84
|
Thanks again @methane for the detailed suggestions! I really appreciate how much you've been able to help with this PR, I think it will definitely pay off since this section applies universally to any contributor since most will end up writing a Misc/NEWS entry at some point. Overall, I agree with the major changes you made, but I had a few minor recommendations. I don't mind adding them in myself to the orginal PR, but I wanted to make sure that you agreed with them first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
No description provided.