docs(v2): Add "PptxGenJS" to showcase#4602
Merged
Merged
Conversation
|
[V2] Built without sensitive environment variables with commit 05314d3 |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4602--docusaurus-2.netlify.app/ |
slorber
reviewed
Apr 12, 2021
slorber
reviewed
Apr 12, 2021
slorber
requested changes
Apr 12, 2021
Collaborator
slorber
left a comment
slorber
left a comment
There was a problem hiding this comment.
Thanks, almost LGTM, just the source is targeting the gh-pages deployment in place of your site's source code
| description: 'PowerPoint JavaScript Library', | ||
| preview: require('./showcase/pptxgenjs.png'), | ||
| website: 'https://gitbrent.github.io/PptxGenJS/', | ||
| source: 'https://github.com/gitbrent/PptxGenJS/tree/gh-pages', |
Collaborator
There was a problem hiding this comment.
can you change this source url to the repo where the Docusaurus site sources are? (I mean, not the built HTML files)
|
[V1] Built with commit d0fed96 |
|
[V1] Built with commit 0bf30ba |
slorber
added
the
pr: documentation
slorber
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Adding new site to showcase.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Run yarn run start:v2 and check that the page http://localhost:3000/showcase is rendered properly.
Related PRs
No