Fixes output filter field icon cannot be tabbed to, only shift-tabbed #117832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isidorn
requested changes
Mar 1, 2021
| @@ -428,6 +428,8 @@ export class ActionBar extends Disposable implements IActionRunner { | |||
| protected focusNext(): boolean { | |||
| if (typeof this.focusedItem === 'undefined') { | |||
| this.focusedItem = this.viewItems.length - 1; | |||
| } else if (this.viewItems.length <= 1) { | |||
There was a problem hiding this comment.
I do not like this line, since ActionBar has a preventLoopNavigation flag. So by default we allow loop navigation. When you are on the last one and press next -> first one is focused
There was a problem hiding this comment.
Yeah but this is for the case when actionbar has only one action and is already focused, so pressing next won't change the focused action.
| @@ -450,6 +452,8 @@ export class ActionBar extends Disposable implements IActionRunner { | |||
| protected focusPrevious(): boolean { | |||
| if (typeof this.focusedItem === 'undefined') { | |||
| this.focusedItem = 0; | |||
| } else if (this.viewItems.length <= 1) { | |||
There was a problem hiding this comment.
Same as my comment in focusNext()
|
@jeanp413 thanks for the PR. Good changes. I have comment in the PR with some things that potentially need to be changed. Let me know what you think. |
isidorn
approved these changes
Mar 1, 2021
|
Thanks, looks good, merging in. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This PR fixes #117354