bpo-28724: Move socket.send_fds and socket.recv_fds documentation to the "Other functions" section #22608
+27
−24
Conversation
|
Looks reasonable to me! |
|
This PR is stale because it has been open for 30 days with no activity. |
gousaiyang
changed the title
…the "Other functions" section
gousaiyang
force-pushed the
gousaiyang:socket-sendrecvfd-doc
branch
from
2c461f7
to
0c875b3
methane
merged commit 660592f
into
python:master
12 checks passed
12 checks passed
bedevere/news
"skip news" label found
|
Thanks @gousaiyang for the PR, and @methane for merging it |
miss-islington
added a commit
to miss-islington/cpython
that referenced
this pull request
Apr 22, 2021
…t section (pythonGH-22608) (cherry picked from commit 660592f) Co-authored-by: Saiyang Gou <gousaiyang@163.com>
|
GH-25517 is a backport of this pull request to the 3.9 branch. |
|
Sorry, @gousaiyang and @methane, I could not cleanly backport this to |
|
We don't need to backport this to 3.8 as those features are 3.9+. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Move
socket.send_fdsandsocket.recv_fdsdocumentation to the "Other functions" section, since they are module-level functions rather than methods of socket objects. Putting them in the "Socket Objects" section would make people incorrectly think that they are methods of socket objects, which is confusing.https://bugs.python.org/issue28724