Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-43770: Cleanup type_ready() #25388

Merged
merged 1 commit into from Apr 13, 2021
Merged

bpo-43770: Cleanup type_ready() #25388

merged 1 commit into from Apr 13, 2021

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Apr 13, 2021 •
edited by bedevere-bot

  • Rename functions
  • Only pass type parameter to "add_xxx" functions.
  • Clarify the role of the type_ready_inherit_as_structs() function.
  • Move type_dict_set_doc() code to call it in type_ready_fill_dict().

https://bugs.python.org/issue43770

@vstinner
bpo-43770: Cleanup type_ready()
8ff6f02 
* Rename functions
* Only pass type parameter to "add_xxx" functions.
* Clarify the role of the type_ready_inherit_as_structs() function.
* Move type_dict_set_doc() code to call it in type_ready_fill_dict().
@vstinner vstinner requested a review from markshannon as a code owner Apr 13, 2021
@vstinner vstinner merged commit a328d73 into python:master Apr 13, 2021
10 checks passed
@vstinner vstinner deleted the type_ready3 branch Apr 13, 2021
kreathon pushed a commit to kreathon/cpython that referenced this pull request May 2, 2021
@vstinner @kreathon
bpo-43770: Cleanup type_ready() (pythonGH-25388)
fc48aa1 
* Rename functions
* Only pass type parameter to "add_xxx" functions.
* Clarify the role of the type_ready_inherit_as_structs() function.
* Move type_dict_set_doc() code to call it in type_ready_fill_dict().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markshannon markshannon

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vstinner @the-knights-who-say-ni @bedevere-bot