Skip to content

/ components

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: require reviews to be completed for all PRs before merging #22200

Merged
merged 1 commit into from Mar 19, 2021
Merged

build: require reviews to be completed for all PRs before merging #22200

merged 1 commit into from Mar 19, 2021
+1 −1

Conversation

@josephperrott
Copy link
Member

@josephperrott josephperrott commented Mar 11, 2021

Enable the requireReviews option for the Angular Github robot checks,
requiring reviews to be completed before a passing status is provided.
@josephperrott
build: require reviews to be completed for all PRs before merging
Loading status checks…
4b90762 
Enable the `requireReviews` option for the Angular Github robot checks,
requiring reviews to be completed before a passing status is provided.
@josephperrott josephperrott added merge safe target: patch area: build labels Mar 11, 2021
@josephperrott josephperrott requested a review from angular/dev-infra-components as a code owner Mar 11, 2021
@google-cla google-cla bot added the cla: yes label Mar 11, 2021
@josephperrott josephperrott requested review from mmalerba and removed request for angular/dev-infra-components Mar 11, 2021
@mmalerba
mmalerba approved these changes Mar 16, 2021
View changes
Copy link
Contributor

@mmalerba mmalerba left a comment

LGTM
@mmalerba mmalerba added the merge ready label Mar 16, 2021
@andrewseguin andrewseguin merged commit 010dbb6 into angular:master Mar 19, 2021
16 checks passed
16 checks passed
Inclusive Language Check completed with success
Details
ci/angular: merge status All checks passed!
ci/circleci: api_golden_checks Your tests passed on CircleCI!
Details
ci/circleci: bazel_build Your tests passed on CircleCI!
Details
ci/circleci: build_release_packages Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests Your tests passed on CircleCI!
Details
ci/circleci: integration_tests Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: ngcc_compatibility Your tests passed on CircleCI!
Details
ci/circleci: tests_browserstack Your tests passed on CircleCI!
Details
ci/circleci: tests_local_browsers Your tests passed on CircleCI!
Details
ci/circleci: tests_saucelabs Your tests passed on CircleCI!
Details
ci/circleci: upload_release_packages Your tests passed on CircleCI!
Details
ci/circleci: view_engine_build Your tests passed on CircleCI!
Details
ci/circleci: view_engine_test Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
andrewseguin added a commit that referenced this pull request Mar 19, 2021
@josephperrott @andrewseguin
build: require reviews to be completed for all PRs before merging (#2…
Loading status checks…
1a4828e 
…2200)

Enable the `requireReviews` option for the Angular Github robot checks,
requiring reviews to be completed before a passing status is provided.

(cherry picked from commit 010dbb6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmalerba mmalerba

Assignees
No one assigned
Labels
area: build cla: yes merge ready merge safe target: patch
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@josephperrott @mmalerba @andrewseguin