Update rules nodejs #21928
Merged
Update rules nodejs #21928
Conversation
josephperrott
requested review from
devversion,
jelbourn and
angular/dev-infra-components
as
code owners
|
LGTM once Jeremy's comments have been addressed. |
josephperrott
force-pushed the
josephperrott:update-rules-nodejs
branch
from
5c84d21
to
fee339e
josephperrott
force-pushed the
josephperrott:update-rules-nodejs
branch
2 times, most recently
from
b64d8f4
to
7d0b9eb
|
LGTM |
| @@ -3,12 +3,12 @@ | |||
| * want to launch any browser and just enable manual browser debugging. | |||
| */ | |||
|
|
|||
| const bazelKarma = require('@bazel/karma'); | |||
| const bazelKarma = require('@bazel/concatjs'); | |||
jelbourn
Feb 17, 2021
Member
I find it really strange that they changed these rules to live under a package named for the bundler 😕
I find it really strange that they changed these rules to live under a package named for the bundler
josephperrott
Feb 17, 2021
Author
Member
Yeah, my guess is that its about consolidation overall: https://github.com/bazelbuild/rules_nodejs/wiki#introducing-bazelconcatjs
Yeah, my guess is that its about consolidation overall: https://github.com/bazelbuild/rules_nodejs/wiki#introducing-bazelconcatjs
|
Still LGTM with a couple of nits. |
josephperrott
force-pushed the
josephperrott:update-rules-nodejs
branch
2 times, most recently
from
e2faea4
to
5addaed
josephperrott
force-pushed the
josephperrott:update-rules-nodejs
branch
from
4623415
to
54834e2
Update to use rules_nodejs@3.1.0 and update correseponding build rule usages and references
Loading the dev-infra rules via the @npm// workspace as the private @npm_dev_infra_private repo is no longer published.
… type Update JSON.parse usages to be better typed rather than resulting in an any type.
… as a type Update JSON.parse usages to be better typed rather than resulting in an any type.
josephperrott
force-pushed the
josephperrott:update-rules-nodejs
branch
from
54834e2
to
6676d3e
josephperrott
removed request for
angular/dev-infra-components,
devversion and
mmalerba
andrewseguin
merged commit 496867d
into
angular:master
16 checks passed
16 checks passed
ci/angular: merge status
All checks passed!
cla/google
All necessary CLAs are signed
| @@ -0,0 +1 @@ | |||
| 12.14.1 | |||
Splaktar
Mar 11, 2021
Member
Is there any reason this can't just be 12? As is, it won't let me commit when I'm using NodeJS 12.21.0.
Is there any reason this can't just be 12? As is, it won't let me commit when I'm using NodeJS 12.21.0.
josephperrott
Mar 11, 2021
Author
Member
The intention is that by using the exact same version here and on CI, there are not any unexpected differences between our usages.
The intention is that by using the exact same version here and on CI, there are not any unexpected differences between our usages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
See individual commits.