JS: Promote js/template-object-injection out of experimental #5369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erik-krogh
added
the
Awaiting evaluation
erik-krogh
removed
the
Awaiting evaluation
asgerf
reviewed
Mar 15, 2021
Contributor
asgerf
left a comment
asgerf
left a comment
There was a problem hiding this comment.
Thanks for porting this over! Looks good, just some nitpicks in the change note and qhelp.
javascript/ql/src/Security/CWE-073/TemplateObjectInjection.qhelp
Outdated
Show resolved
Hide resolved
javascript/ql/src/Security/CWE-073/TemplateObjectInjection.qhelp
Outdated
Show resolved
Hide resolved
javascript/change-notes/2021-03-09-template-object-injection.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Asger F <asgerf@github.com>
asgerf
approved these changes
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a template engine filter based on an investigation by @agustingianni.
/cc @CaptainFreak - I thought you might be interested in this.
Performance looks fine. I used a baseline that was a
where none()edition of the query evaluated withTaintedPath.ql.It shows a slight spurious performance improvement.