Skip to content

/ storybook

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BigInt support in TeleJSON #13950

Open
JesusTheHun opened this issue Feb 18, 2021 · 2 comments
Open

BigInt support in TeleJSON #13950

JesusTheHun opened this issue Feb 18, 2021 · 2 comments
Assignees
@phated
Labels
P2 args bug good first issue help wanted

Comments

@JesusTheHun
Copy link

@JesusTheHun JesusTheHun commented Feb 18, 2021 •
edited

Currently is you set a component property to an object carrying a BigInt the entire storybook stops functioning. The console logs show an error trying to serialize this object.

Uncaught TypeError: Do not know how to serialize a BigInt
    at JSON.stringify (<anonymous>)
    (...)

Code sample to help you get the context :

const invitations = {
  isLoading: false,
  entities: [{
    id: 'd25b99c9-4908-44c6-8ce4-d73768b967c6',
    revision: BigInt(1602168054734520320),
    firstName: 'Foo',
    lastName: 'Bar',
    email: 'foo.bar@provider.com',
  }]
};

export default {
  title: 'Acme/Modules/Invitations/InvitationsList',
  component: InvitationsList,
} as Meta;

const Template: Story<InvitationsListProps> = (args) => <InvitationsList {...args} />;

export const Default = Template.bind({});
Default.args = {
  invitations
};

Switching to json-bigint which is a drop-in replacement would solve this issue in a blink.
@phated
Copy link
Contributor

@phated phated commented Feb 22, 2021

@shilman want me to add this to telejson? I think it can just be a toString and then put it back into a BigInt on parse
@shilman
Copy link
Member

@shilman shilman commented Feb 25, 2021

@phated sure! 🙏
@ghengeveld ghengeveld changed the title BigInt support for template args BigInt support in TeleJSON Feb 26, 2021
@JesusTheHun JesusTheHun mentioned this issue Feb 26, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phated phated

Labels
P2 args bug good first issue help wanted
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@JesusTheHun @shilman @phated