Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally integrate Zoom SDK for video calls #205

Merged
merged 3 commits into from Mar 6, 2021
Merged

Optionally integrate Zoom SDK for video calls #205

merged 3 commits into from Mar 6, 2021

Conversation

Copy link
Member

@raphaelm raphaelm commented Mar 6, 2021

  • expose options to disable chat, …
  • pass custom translation

@codecov
Copy link

@codecov codecov bot commented Mar 6, 2021

Codecov Report

Merging #205 (ae69426) into dev (6c8cd52) will decrease coverage by 0.33%.
The diff coverage is 50.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #205      +/-   ##
==========================================
- Coverage   79.32%   78.99%   -0.34%     
==========================================
  Files          94       97       +3     
  Lines        7309     7394      +85     
  Branches      695      704       +9     
==========================================
+ Hits         5798     5841      +43     
- Misses       1382     1421      +39     
- Partials      129      132       +3     
Impacted Files Coverage Δ
server/venueless/core/models/world.py 97.77% <ø> (ø)
server/venueless/zoom/views.py 40.38% <40.38%> (ø)
server/venueless/middleware.py 45.45% <45.45%> (ø)
server/venueless/live/modules/zoom.py 73.68% <73.68%> (ø)
server/venueless/core/permissions.py 100.00% <100.00%> (ø)
server/venueless/live/consumers.py 92.90% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c8cd52...16aa986. Read the comment docs.

@raphaelm raphaelm merged commit 172f9b4 into dev Mar 6, 2021
7 checks passed
@raphaelm raphaelm deleted the zoom-sdk branch Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant